From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFcml-0007Dz-9v for qemu-devel@nongnu.org; Mon, 26 Jan 2015 01:04:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFcmi-00009n-0C for qemu-devel@nongnu.org; Mon, 26 Jan 2015 01:04:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFcmh-00009h-Pz for qemu-devel@nongnu.org; Mon, 26 Jan 2015 01:04:27 -0500 Date: Mon, 26 Jan 2015 14:04:21 +0800 From: Fam Zheng Message-ID: <20150126060421.GE2354@ad.nay.redhat.com> References: <1421938053-10318-1-git-send-email-pbonzini@redhat.com> <1421938053-10318-6-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1421938053-10318-6-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 05/15] memory: remove assertion on memory_region_destroy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: borntraeger@de.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com, Jan Kiszka On Thu, 01/22 15:47, Paolo Bonzini wrote: > From: Jan Kiszka > > Now that memory_region_destroy can be called from an RCU callback, > checking the BQL-protected global memory_region_transaction_depth > does not make much sense. > > Signed-off-by: Jan Kiszka > Signed-off-by: Paolo Bonzini > --- > memory.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/memory.c b/memory.c > index c343bf3..8c3d8c0 100644 > --- a/memory.c > +++ b/memory.c > @@ -1263,7 +1263,6 @@ static void memory_region_finalize(Object *obj) > MemoryRegion *mr = MEMORY_REGION(obj); > > assert(QTAILQ_EMPTY(&mr->subregions)); > - assert(memory_region_transaction_depth == 0); > mr->destructor(mr); > memory_region_clear_coalescing(mr); > g_free((char *)mr->name); > -- > 1.8.3.1 > > Reviewed-by: Fam Zheng