From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGNUP-0002Ra-VY for qemu-devel@nongnu.org; Wed, 28 Jan 2015 02:56:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGNUL-0006EO-UX for qemu-devel@nongnu.org; Wed, 28 Jan 2015 02:56:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGNUL-0006EK-LX for qemu-devel@nongnu.org; Wed, 28 Jan 2015 02:56:37 -0500 Date: Wed, 28 Jan 2015 09:56:26 +0200 From: "Michael S. Tsirkin" Message-ID: <20150128075626.GA16660@redhat.com> References: <20150123132424.GA4579@redhat.com> <20150123144030.21142ed1@nial.brq.redhat.com> <20150123135511.GF4579@redhat.com> <20150123185620.604b83ab@nial.brq.redhat.com> <20150124163350.GC6293@redhat.com> <20150126105721.60641e59@nial.brq.redhat.com> <20150126160920.79a09b37@nial.brq.redhat.com> <20150126153400.GB3536@hawk.usersys.redhat.com> <20150126161755.GA5487@redhat.com> <20150127232909.6c045626@igors-macbook-pro.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150127232909.6c045626@igors-macbook-pro.local> Subject: Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: pbonzini@redhat.com, Andrew Jones , claudio.fontana@huawei.com, qemu-devel@nongnu.org, marcel.a@redhat.com > I've tried redo series with passing alloc list as first argument, > looks ugly as hell I tried too. Not too bad at all. See below: diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index f66da5d..820504a 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -491,14 +491,14 @@ static void acpi_set_pci_info(void) } } -static void build_append_pcihp_notify_entry(AcpiAml *method, int slot) +static void build_append_pcihp_notify_entry(AmlPool *p, AcpiAml *method, int slot) { - AcpiAml if_ctx; + AcpiAml *if_ctx; int32_t devfn = PCI_DEVFN(slot, 0); - if_ctx = acpi_if(acpi_and(acpi_arg0(), acpi_int(0x1U << slot))); - aml_append(&if_ctx, acpi_notify(acpi_name("S%.02X", devfn), acpi_arg1())); - aml_append(method, if_ctx); + if_ctx = acpi_if(p, acpi_and(p, acpi_arg0(), acpi_int(p, 0x1U << slot))); + aml_append(p, if_ctx, acpi_notify(p, acpi_name(p, "S%.02X", devfn), acpi_arg1(p))); + aml_append(p, method, if_ctx); } static void build_append_pci_bus_devices(AcpiAml *parent_scope, PCIBus *bus, What exactly is the problem? A tiny bit more verbose but the lifetime of all objects is now explicit. -- MST