From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGVOj-0007a0-7Q for qemu-devel@nongnu.org; Wed, 28 Jan 2015 11:23:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGVOf-0007jY-CM for qemu-devel@nongnu.org; Wed, 28 Jan 2015 11:23:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGVOf-0007jR-5t for qemu-devel@nongnu.org; Wed, 28 Jan 2015 11:23:17 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SGNFgm029261 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 28 Jan 2015 11:23:16 -0500 Date: Wed, 28 Jan 2015 17:21:28 +0100 From: Peter Krempa Message-ID: <20150128162128.GD5003@andariel.home> References: <022e72b53701099e5e7526fcbaa6655bdb5593ab.1422433899.git.pkrempa@redhat.com> <20150128132941.6c593d29@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ieNMXl1Fr3cevapt" Content-Disposition: inline In-Reply-To: <20150128132941.6c593d29@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCHv2 1/2] vl.c: Fix error messages when parsing maxmem parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Paolo Bonzini , qemu-devel@nongnu.org --ieNMXl1Fr3cevapt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 28, 2015 at 13:29:41 +0100, Igor Mammedov wrote: > On Wed, 28 Jan 2015 09:35:03 +0100 > Peter Krempa wrote: >=20 > > Produce more human readable error messages and fix few spelling > > mistakes. > >=20 > > Also remove a redundant check for the max memory size. > >=20 > > Signed-off-by: Peter Krempa > > --- > >=20 > > Notes: > > Version 2: > > - fixed spacing in error message > > - changed control flow to allow maxmem =3D=3D ram_size in case slot= s =3D=3D 0 > >=20 > > vl.c | 34 ++++++++++++++++------------------ > > 1 file changed, 16 insertions(+), 18 deletions(-) > >=20 > > diff --git a/vl.c b/vl.c > > index 983259b..5a012f4 100644 > > --- a/vl.c > > +++ b/vl.c > > @@ -2694,29 +2694,27 @@ static void set_memory_options(uint64_t *ram_sl= ots, ram_addr_t *maxram_size) > > uint64_t slots; > >=20 > > sz =3D qemu_opt_get_size(opts, "maxmem", 0); > > + slots =3D qemu_opt_get_number(opts, "slots", 0); > > if (sz < ram_size) { > > - error_report("invalid -m option value: maxmem " > > - "(0x%" PRIx64 ") <=3D initial memory (0x" > > - RAM_ADDR_FMT ")", sz, ram_size); > > + error_report("invalid value of -m option maxmem: " > > + "maximum memory size (0x%" PRIx64 ") must at = least " > typo?? > "must be at least" >=20 Hmm, right. Should I respin the series to fix it? Peter --ieNMXl1Fr3cevapt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUyQyIAAoJEDbsFqzQGGgr7WgQAIDKxe7Kia6eMXjGpuzA5C87 be5o8ENnkszQYHTYGo2zXDkYV46zT0vt/b13xZAMh6tyoeYtcxpCL6ZHcj8nmEsm J8DZP0oVnzBIVPm/X11ieQ8z6h99E4mvjELe/IZ5bB6vBhr0T2hBa539j9jICy8J Cp/YpKJl5qjg9uvAlBRxZKq4F+Em2c8yila4ADILXnN2lkOxrDnxQ71v7yyXa8/X t0yQIfh1SaW5K+TXRd6FqiLeeIQWd1EYLQGicip5RFDKkeyUv7E1MUjwg7uWUftZ YlL7CktL56HQN8z6EVG05MxZQyb9LxnJKvvx19WquD8cTuJ0DBy/BIU8RbbjQNKJ sSO1YNV7DntgHaj2ThJb9dLl6wzNfMgESv96X7upPbWuErGyjzZfU24LbFtEFjEW mhosu7XCb5v+0gEEkzKnWt1ADCxcr9JORSfPZAvCfBs+0jHizwhhTMJdqj1DjhSc xkzZFhOEbarjaNMN1ETfKShHOITa+gZxUY1TaPjLa38ST/j75pL7h3Lox35lZ1Nv hdMcsY/igivIUUMnuDkbND21AL0pkN2ied4BgvADtQSA+Ws09cmxNL3lkPCgDHd7 O9X1WVUFke5CPleMXVu5RRM/MuptdxgZbjjEuj1NFtTnzx3a41Jh2X8i0vW76CV6 vdgCVPipFH3BxKdincU3 =UcKU -----END PGP SIGNATURE----- --ieNMXl1Fr3cevapt--