From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGd0X-0000ca-Ds for qemu-devel@nongnu.org; Wed, 28 Jan 2015 19:30:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGd0W-00080p-6H for qemu-devel@nongnu.org; Wed, 28 Jan 2015 19:30:53 -0500 Date: Thu, 29 Jan 2015 11:29:25 +1100 From: David Gibson Message-ID: <20150129002925.GH14681@voom> References: <1422339213-23426-1-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GBuTPvBEOL0MYPgd" Content-Disposition: inline In-Reply-To: <1422339213-23426-1-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH v2] spapr_vio/spapr_iommu: Move VIO bypass where it belongs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf --GBuTPvBEOL0MYPgd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 27, 2015 at 05:13:32PM +1100, Alexey Kardashevskiy wrote: > Instead of tweaking a TCE table device by adding there a bypass flag, > let's add an alias to RAM and IOMMU memory region, and enable/disable > those according to the selected bypass mode. > This way IOMMU memory region can have size of the actual window rather > than ram_size which is essential for upcoming DDW support. >=20 > This moves bypass logic to VIO layer and keeps @bypass flag in TCE table > for migration compatibility only. This replaces spapr_tce_set_bypass() > calls with explicit assignment to avoid confusion as the function could > do something more that just syncing the @bypass flag. >=20 > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v2: > * kept @bypass in sPAPRTCETable not to break migration So, the bypass field definition in the struct should probably get a comment explaining how it's only used for migration compatibility now. Apart from that: Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --GBuTPvBEOL0MYPgd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUyX7lAAoJEGw4ysog2bOSyu4QAOTxLMWHSIZCFihGxG5BXNbS nXZJXRrYPV161+yOYXFXEvLTF4TikfC/LMw8tXauObWqL1QVTOW9Nlpfi7qZsWUx Kn2uKA7PgZLHHpPkJjZZdysfJS7NcpkPjQwbPBSa06w3weVUytgex53083nOjczx cacviNs8Y5I7WTqQFmAbr1vIW7HZB6yQNbXt2awBZSHPwgrKSBtYxWe46bOPBgHe oV0mTbdOGnzTVJ0KK5DqCq9zlKVm87MqW5OaJFJLheZusDNjE+AxWL+2oNPBaD8t L2dMSca5o1gblM7peeZh+WnHa+G5aM4TbBWUnVMTCnLJ+M8LcL4B7g/i+EBmWz2D dr54fPuJ3BPCiVb8tLaqqCjmKSQvEeKivgCakoB0Pcl8l10WuNwjbNiB+wVeje2l m3RRsdpfqXazOLj8w9BlP+JkCW45euY1F3Jon19t3WEQMEDyNY5a7SwVIJUbf9YE /jfUzfxDUNIWicdE4yFxfc3PWQLzCeB2EgOutVXidNW/xkLUTE9sGQYJYeoVpoFl mm85bz0k+7M4k5XzOoHeMnVVsBvDYz5uqvbv+hRsceh0kr0CIBTzKVNS/TGoHizZ bYkIVzTAPbcXzzUqzW0LBly2Eusz5mlkSIC6xQvRLQbll5ZpsNaN/ihTDueYtKw2 y52bPnPRGpwmORK9VJL/ =tgZj -----END PGP SIGNATURE----- --GBuTPvBEOL0MYPgd--