From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGeE4-0000nw-RH for qemu-devel@nongnu.org; Wed, 28 Jan 2015 20:49:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGeDt-0000Xa-0c for qemu-devel@nongnu.org; Wed, 28 Jan 2015 20:48:56 -0500 Date: Thu, 29 Jan 2015 11:48:47 +1100 From: David Gibson Message-ID: <20150129004847.GK14681@voom> References: <1422282118-22507-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cy9Nn4fUvYST66Pl" Content-Disposition: inline In-Reply-To: <1422282118-22507-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH] target-ppc: Use right page size with hash table lookup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, paulus@samba.org, agraf@suse.de, Anton Blanchard --cy9Nn4fUvYST66Pl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 26, 2015 at 07:51:58PM +0530, Aneesh Kumar K.V wrote: > We look at two sizes specified in ISA (4K, 64K). If not found matching, > we consider it 16MB. >=20 > Without this patch we would fail to lookup address above 16MB range. > Below 16MB happened to work before because the kernel have a liner > mapping and we always looked up hash for 0xc000000000000000. The > actual real address was computed by using the 16MB offset > with the real address found with the above hash. >=20 > Without Fix: > (gdb) x/16x 0xc000000001000000 > 0xc000000001000000 : Cannot access memory at a= ddress 0xc000000001000000 > (gdb) >=20 > With Fix: > (gdb) x/16x 0xc000000001000000 > 0xc000000001000000 : 0x00000000 0x0000000= 0 0x00000000 0x00000000 > 0xc000000001000010 : 0x00000000 0x0000000= 0 0x00000000 0x00000000 > 0xc000000001000020 : 0x00000000 0x0000000= 0 0x00000000 0x00000000 > 0xc000000001000030 : 0x00000000 0x0000000= 0 0x00000000 0x00000000 >=20 > Signed-off-by: Aneesh Kumar K.V This doesn't fully implement the sllp page size encodings, but it's certainly better than what's there now. Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --cy9Nn4fUvYST66Pl Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUyYNvAAoJEGw4ysog2bOSgdcQAOE4YCOo8/QIjr73Q0BMCNrG /vWcHDURhX+RWFY6GEf8SnGDg2wocK7yWynVOJU1VUt1/PIINU+iSb6hKI6/UHIo qV+w25LNESqdAv5zNV0BvV4+dSZt4TX8UxPI7ffVddYiW7v2ZMpqYLygyNlMCN3+ I/x9pHWE95+Po8id5YOwmbNSPkghppNcFNIz2QkQqCMTU+Cpb/V5hgCWHfASdP3c paTuV/tMTwNT2XjatS3fzWuPtulsUF5PXVMFd8iuNjF8kn23nalxSXm562G5ABI7 mYQqLjpInXww8Wgx50HHDKS2lSUBTCul0NtlGNGj7s4coBNP/fIs8Fam3Z96+AIQ ZXVoyxRsHRb+kKDGwbiP4Vpu1QKutdy4aN9zsbbMBvSkqJxbyzHtXv5PA5pSlv/l CAbYmGOmi3uy9cVasYW3m1qtTxbh95mwcejuajxvwWuqhhJMASj59GHjqkghuOwY 20FDMkQzScPJVqNCIMkUFWDh0hfyRcRztNi6Q1/GUlBx11t8ONou56sDpV9D/che sFs60PpwnTtcP+m6ijLME8NkAqHHpZoZUZNoIVEnrX9rf5zztUgVFCaJcPsIx7Ws yvHJfNPt9TaT/Jz+i7V5EPK8IKEpiu+u8oHifUwIzSFxv90qbxv7NNAZWqaQbeuw mdCp7y/l8v1PQxokTSLu =pAD4 -----END PGP SIGNATURE----- --cy9Nn4fUvYST66Pl--