From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGgL0-0003Gq-T6 for qemu-devel@nongnu.org; Wed, 28 Jan 2015 23:04:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGgKw-0001xA-Ro for qemu-devel@nongnu.org; Wed, 28 Jan 2015 23:04:14 -0500 Date: Thu, 29 Jan 2015 13:32:40 +1100 From: David Gibson Message-ID: <20150129023240.GU14681@voom> References: <1422339213-23426-1-git-send-email-aik@ozlabs.ru> <54C8015E.6070801@ozlabs.ru> <54C8A2AC.9020203@ozlabs.ru> <20150129003109.GI14681@voom> <54C9836E.1060407@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gYb7txo4D4wAJl1C" Content-Disposition: inline In-Reply-To: <54C9836E.1060407@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH v2] spapr_vio/spapr_iommu: Move VIO bypass where it belongs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Paolo Bonzini , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf --gYb7txo4D4wAJl1C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 29, 2015 at 11:48:46AM +1100, Alexey Kardashevskiy wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > On 01/29/2015 11:31 AM, David Gibson wrote: > > On Wed, Jan 28, 2015 at 07:49:48PM +1100, Alexey Kardashevskiy wrote: > >> On 01/28/2015 08:21 AM, Alexey Kardashevskiy wrote: > >>> On 01/27/2015 05:13 PM, Alexey Kardashevskiy wrote: > > [snip] > >>>> diff --git a/include/hw/ppc/spapr_vio.h > >>>> b/include/hw/ppc/spapr_vio.h index 46edc2a..6ad55d1 100644 --- > >>>> a/include/hw/ppc/spapr_vio.h +++ b/include/hw/ppc/spapr_vio.h @@ > >>>> -64,6 +64,8 @@ struct VIOsPAPRDevice { target_ulong > >>>> signal_state; VIOsPAPR_CRQ crq; AddressSpace as; + > >>>> MemoryRegion mrroot; + MemoryRegion mrbypass; sPAPRTCETable > >>>> *tcet; }; > >>>>=20 > >>>>=20 > >>>=20 > >>>=20 > >>=20 > >>=20 > >> I believe doing something like this is way too disguising because > >> of tobj->parent? > >=20 > > It's kinda ugly, but it's the best way I can think of. >=20 >=20 >=20 > Better than having VIOsPAPRDevice pointer in sPAPRTCETable? I would > expect a object_get_parent() helper to exist but it is not there and I > believe this is for a reason (may be it will be get rid of some time > later)... Uh.. I think someone who knows qom better than me will have to answer that.. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --gYb7txo4D4wAJl1C Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUyZvIAAoJEGw4ysog2bOSH8gQAIH8+TuXSzgLh/2TZzFys+Bg F5iC817rac+PkkoCdSLLTDLWj1PrkTlV1tuqf9aUvtyshZ+9FukI8lvjZooNfDUG 8dzj3UK5rcRaDP88lh0ATKzut/JPoN4Usodcj+KNwQhB5opWxO/d/Jo3rlO8hCko VZiHG7600yMgTg/91jTx7ctfP3lpNyMJ4Te8LzuJPPGrjPna0DpYKeKJ+f1ZZst6 Pt9lUSDTK9uRdpgmwRn8sLNNZThXRvRn++kLWTVKvAj0ZmI61OiJerIPhPwgkX9n Iy/N1trwyItvpEDFaKR56CyAaRxwPg1mVdB5zFt/mUD/bcegg9L/X7U/x094nRBw 5ZRqtDAxvF5uCVPt86JCFla9oZIB0a1ZAYysJXRrHJLizXQCw4ovfQWG0nFq+r6X s/yHYP1u0662tRovcYpJwtYFbLL+WhWl91PNe4gT9UZvn1E1u59AsrUaJRS7B+cU 57cMBcO+ikG5abShfPyM9UePo+mxMXV6h+zssQRqFhKzaFEghRHHy2CgK7MG8YCf S4+QvX1EkJrtDnoXgbXsC21zyrnAa7Wr8pses8u6H0jrsS6543vXVs1EuL5mAf3A kOdjUGEkt3hjw585M09RkgUwXykPHrvcf0VtHROv43yct8BQ3slv+qWDEzpk9lgt YJug1YUwwh+Wk3Qgu6ph =Y97q -----END PGP SIGNATURE----- --gYb7txo4D4wAJl1C--