From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGvbK-0007xw-1k for qemu-devel@nongnu.org; Thu, 29 Jan 2015 15:22:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGvbE-0005fM-UR for qemu-devel@nongnu.org; Thu, 29 Jan 2015 15:22:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGvbE-0005fH-MY for qemu-devel@nongnu.org; Thu, 29 Jan 2015 15:22:00 -0500 Date: Thu, 29 Jan 2015 20:21:55 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150129202154.GH2391@work-vm> References: <1422543997-22808-1-git-send-email-dgilbert@redhat.com> <1422543997-22808-2-git-send-email-dgilbert@redhat.com> <20150129151527.GE1102@redhat.com> <54CA500E.8030608@redhat.com> <20150129155425.GE2391@work-vm> <54CA594E.5030605@redhat.com> <20150129162815.GG2391@work-vm> <54CA71CD.3090304@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54CA71CD.3090304@redhat.com> Subject: Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: amit.shah@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, quintela@redhat.com * Eric Blake (eblake@redhat.com) wrote: > On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: > > > > So what would the .args_type look like in qmp-commands.hx; something like this? > > > > .args-type = "type:s,port:-i,host:-s,command:-s" > > No, it would be more like the blockdev-add interface, where one command > accepts a dictionary object containing a union of valid values, where > the set of valid values is determined by the discriminator field. > .args_type = "options:q". What causes the parser to generate a 'BlockdevOptions' as opposed to any standard options type for the parameter of qmp_blockdev_add? Dave > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK