From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33389)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1YH0mZ-00009B-Bk
	for qemu-devel@nongnu.org; Thu, 29 Jan 2015 20:54:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1YH0mV-0007Pi-EK
	for qemu-devel@nongnu.org; Thu, 29 Jan 2015 20:54:03 -0500
Received: from mail-ob0-x22a.google.com ([2607:f8b0:4003:c01::22a]:36119)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1YH0mV-0007PY-8v
	for qemu-devel@nongnu.org; Thu, 29 Jan 2015 20:53:59 -0500
Received: by mail-ob0-f170.google.com with SMTP id wp4so21458609obc.1
	for <qemu-devel@nongnu.org>; Thu, 29 Jan 2015 17:53:58 -0800 (PST)
Date: Fri, 30 Jan 2015 11:49:57 +1000
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20150130014957.GE8636@toto>
References: <1422557717-19120-1-git-send-email-peter.maydell@linaro.org>
	<1422557717-19120-7-git-send-email-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1422557717-19120-7-git-send-email-peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 06/11] target-arm: Don't define any
	MMU_MODE*_SUFFIXes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Andrew Jones <drjones@redhat.com>, Greg Bellows <greg.bellows@linaro.org>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, qemu-devel@nongnu.org, patches@linaro.org

On Thu, Jan 29, 2015 at 06:55:12PM +0000, Peter Maydell wrote:
> target-arm doesn't use any of the MMU-mode specific cpu ldst
> accessor functions. Suppress their generation by not defining
> any of the MMU_MODE*_SUFFIX macros. ("user" and "kernel" are
> too simplistic as descriptions of indexes 0 and 1 anyway.)
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Greg Bellows <greg.bellows@linaro.org>

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

> ---
>  target-arm/cpu.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index cf47952..b45280d 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -1638,8 +1638,6 @@ typedef enum ARMMMUIdx {
>      ARMMMUIdx_S1NSE1 = 8,
>  } ARMMMUIdx;
>  
> -#define MMU_MODE0_SUFFIX _user
> -#define MMU_MODE1_SUFFIX _kernel
>  #define MMU_USER_IDX 0
>  
>  /* Return the exception level we're running at if this is our mmu_idx */
> -- 
> 1.9.1
>