From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1YH6gd-00021s-38
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 03:12:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1YH6gV-0008T1-UW
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 03:12:19 -0500
Received: from e28smtp04.in.ibm.com ([122.248.162.4]:34511)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1YH6gV-0008SV-8T
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 03:12:11 -0500
Received: from /spool/local
	by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <bharata@linux.vnet.ibm.com>;
	Fri, 30 Jan 2015 13:42:08 +0530
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by d28dlp01.in.ibm.com (Postfix) with ESMTP id C8F30E0045
	for <qemu-devel@nongnu.org>; Fri, 30 Jan 2015 13:43:27 +0530 (IST)
Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63])
	by d28relay05.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
	t0U8C4YB3211548
	for <qemu-devel@nongnu.org>; Fri, 30 Jan 2015 13:42:04 +0530
Received: from d28av01.in.ibm.com (localhost [127.0.0.1])
	by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	t0U8C3pP017207
	for <qemu-devel@nongnu.org>; Fri, 30 Jan 2015 13:42:03 +0530
Date: Fri, 30 Jan 2015 13:42:00 +0530
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Message-ID: <20150130081200.GD24041@in.ibm.com>
References: <1420697420-16053-1-git-send-email-bharata@linux.vnet.ibm.com>
	<1420697420-16053-8-git-send-email-bharata@linux.vnet.ibm.com>
	<20150129013655.GR14681@voom>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150129013655.GR14681@voom>
Subject: Re: [Qemu-devel] [RFC PATCH v1 07/13] spapr: Start all the threads
 of CPU core when core is hotplugged
Reply-To: bharata@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: imammedo@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On Thu, Jan 29, 2015 at 12:36:55PM +1100, David Gibson wrote:
> On Thu, Jan 08, 2015 at 11:40:14AM +0530, Bharata B Rao wrote:
> > PowerPC kernel adds or removes CPUs in core granularity and hence
> > onlines/offlines all the SMT threads of a core during hot plug/unplug.
> > Support this notion by starting all SMT threads of a core when a core
> > is hotplugged.
> > 
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> > ---
> >  hw/ppc/spapr.c | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > index a293a59..4347471 100644
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -1376,6 +1376,8 @@ static void spapr_drc_reset(void *opaque)
> >      }
> >  }
> >  
> > +static const char *current_cpu_model;
> 
> More new global variables?  Please don't.

Sure, I should be able to get the model name from the type name
of the object as Igor suggested earlier.

Regards,
Bharata.