From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH6k9-0003Yp-O4 for qemu-devel@nongnu.org; Fri, 30 Jan 2015 03:15:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YH6k5-0001kA-Nd for qemu-devel@nongnu.org; Fri, 30 Jan 2015 03:15:57 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:38774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH6k5-0001jk-2F for qemu-devel@nongnu.org; Fri, 30 Jan 2015 03:15:53 -0500 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 30 Jan 2015 18:15:47 +1000 Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id CB5C42BB0047 for ; Fri, 30 Jan 2015 19:15:44 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t0U8FiEO47513696 for ; Fri, 30 Jan 2015 19:15:44 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t0U8FhP6028125 for ; Fri, 30 Jan 2015 19:15:43 +1100 Date: Fri, 30 Jan 2015 13:45:31 +0530 From: Bharata B Rao Message-ID: <20150130081531.GE24041@in.ibm.com> References: <1420697420-16053-1-git-send-email-bharata@linux.vnet.ibm.com> <1420697420-16053-10-git-send-email-bharata@linux.vnet.ibm.com> <20150129013958.GS14681@voom> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150129013958.GS14681@voom> Subject: Re: [Qemu-devel] [RFC PATCH v1 09/13] spapr: CPU hot unplug support Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: imammedo@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Thu, Jan 29, 2015 at 12:39:58PM +1100, David Gibson wrote: > On Thu, Jan 08, 2015 at 11:40:16AM +0530, Bharata B Rao wrote: > > Support hot removal of CPU for sPAPR guests. > > > > Signed-off-by: Bharata B Rao > > --- > > hw/ppc/spapr.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index 4347471..ec793b1 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -1908,6 +1908,22 @@ static void spapr_cpu_hotplug_add(DeviceState *dev, CPUState *cs) > > drck->attach(drc, dev, fdt, offset, false); > > } > > > > +static void spapr_cpu_release(DeviceState *dev, void *opaque) > > +{ > > + /* Release vCPU */ > > Um.. should this actually do something? Actual vCPU removal code in the next patch, but as you commented on the next patch, I will clear generic and ppc parts into different patches next time. Regards, Bharata.