From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: amit.shah@redhat.com, liang.z.li@intel.com,
qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line
Date: Fri, 30 Jan 2015 10:02:12 +0000 [thread overview]
Message-ID: <20150130100212.GF2370@work-vm> (raw)
In-Reply-To: <54CB5469.80806@redhat.com>
* Paolo Bonzini (pbonzini@redhat.com) wrote:
>
>
> On 29/01/2015 16:22, Dr. David Alan Gilbert wrote:
> > I'm a bit worried about whether starting an incoming migrate afterwards is
> > different in any subtle way. I can see there are a handful of devices that
> > have 'runstate_check(RUN_STATE_INMIGRATE)' calls in, and thus I'm not sure
> > that starting a paused VM and then flipping to RUN_STATE_INMIGRATE would
> > be quite the same.
>
> Ouch, you're right. Especially BDRV_O_INCOMING is scary.
Yes; I've not got a clue what it's effect is, but given it's glued into
the block code I'm sure that breaking it will be subtle and nasty. I'm
also reasonably sure it's probably going to do something different in the loadvm
case which is probably unintended.
Dave
> Paolo
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2015-01-30 10:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 15:06 [Qemu-devel] [RFC 0/1] Incoming migration vs early monitor commands Dr. David Alan Gilbert (git)
2015-01-29 15:06 ` [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line Dr. David Alan Gilbert (git)
2015-01-29 15:15 ` Daniel P. Berrange
2015-01-29 15:21 ` Eric Blake
2015-01-29 15:54 ` Dr. David Alan Gilbert
2015-01-29 16:01 ` Eric Blake
2015-01-29 16:28 ` Dr. David Alan Gilbert
2015-01-29 17:45 ` Eric Blake
2015-01-29 20:21 ` Dr. David Alan Gilbert
2015-01-29 20:48 ` Eric Blake
2015-01-30 9:38 ` Dr. David Alan Gilbert
2015-01-30 9:50 ` Paolo Bonzini
2015-01-30 9:56 ` Dr. David Alan Gilbert
2015-02-03 10:12 ` Amit Shah
2015-02-03 11:02 ` Paolo Bonzini
2015-01-30 9:50 ` Daniel P. Berrange
2015-01-30 8:34 ` Markus Armbruster
2015-01-30 9:20 ` Dr. David Alan Gilbert
2015-01-30 9:43 ` Markus Armbruster
2015-01-30 8:35 ` Markus Armbruster
2015-01-29 15:22 ` Dr. David Alan Gilbert
2015-01-29 15:31 ` Daniel P. Berrange
2015-01-29 15:46 ` Dr. David Alan Gilbert
2015-01-29 15:50 ` Eric Blake
2015-01-29 15:56 ` Dr. David Alan Gilbert
2015-01-29 15:58 ` Daniel P. Berrange
2015-01-30 9:52 ` Paolo Bonzini
2015-01-30 10:02 ` Dr. David Alan Gilbert [this message]
2015-01-30 10:27 ` Paolo Bonzini
2015-01-29 15:25 ` [Qemu-devel] [RFC 0/1] Incoming migration vs early monitor commands Eric Blake
2015-01-29 23:08 ` Paolo Bonzini
2015-01-30 9:42 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130100212.GF2370@work-vm \
--to=dgilbert@redhat.com \
--cc=amit.shah@redhat.com \
--cc=liang.z.li@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).