From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHE72-0004a4-Km for qemu-devel@nongnu.org; Fri, 30 Jan 2015 11:08:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHE6y-0005Lz-KS for qemu-devel@nongnu.org; Fri, 30 Jan 2015 11:08:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHE6y-0005LR-DQ for qemu-devel@nongnu.org; Fri, 30 Jan 2015 11:08:00 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0UG7wnZ027734 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 30 Jan 2015 11:07:59 -0500 Date: Fri, 30 Jan 2015 16:07:54 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150130160754.GH2370@work-vm> References: <1418148909-19870-1-git-send-email-dgilbert@redhat.com> <20150107162657.GB8871@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150107162657.GB8871@work-vm> Subject: Re: [Qemu-devel] [PATCH 0/2] ATAPI migration fix/hack List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com, jsnow@redhat.com * Dr. David Alan Gilbert (dgilbert@redhat.com) wrote: > > Oops, forgot to include Kevin and Stefan on cc for this. Ping; John R-b'd the two patches: https://lists.gnu.org/archive/html/qemu-devel/2014-12/msg01133.html http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01956.html although hmm, possibly before I added both of you on the cc. Dave > > Dave > > * Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote: > > From: "Dr. David Alan Gilbert" > > > > This pair of patches fixes a problem where IDE/ATAPI cdrom > > reads get lost/corrupted over migration. > > > > The first of the patches (restore atapi_dma flag) is > > a simple fix that I think is safe; it no longer causes > > corruption in the case we saw, but does still trigger > > a long timeout. > > > > The second is a hack; it throws a medium error causing > > the guest to retry the command in the case where migration > > happens just between the IDE/ATAPI command being submitted > > and the bmdma being finished. This recovers a lot > > faster than the timeout. > > > > Only tried on Linux guests so far; I think it might be possible > > to replace both of these by reparsing the command buffer for > > ATAPI; I'm just not confident I know when that's safe to do, > > and I wanted to see how disgusted people were by the 2nd hack. > > > > Dave > > > > Dr. David Alan Gilbert (2): > > Restore atapi_dma flag across migration > > atapi migration: Throw recoverable error to avoid recovery > > > > hw/ide/atapi.c | 17 +++++++++++++++++ > > hw/ide/core.c | 1 + > > hw/ide/internal.h | 2 ++ > > hw/ide/pci.c | 11 +++++++++++ > > 4 files changed, 31 insertions(+) > > > > -- > > 2.1.0 > > > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK