From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38122)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YJDV4-0005YY-7E
	for qemu-devel@nongnu.org; Wed, 04 Feb 2015 22:53:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YJDV0-0006V7-6M
	for qemu-devel@nongnu.org; Wed, 04 Feb 2015 22:53:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52858)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YJDUz-0006V0-Tu
	for qemu-devel@nongnu.org; Wed, 04 Feb 2015 22:53:02 -0500
Date: Thu, 5 Feb 2015 11:52:55 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150205035255.GA7531@ad.nay.redhat.com>
References: <1423107872-3268-1-git-send-email-chenxg@linux.vnet.ibm.com>
	<1423107872-3268-2-git-send-email-chenxg@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1423107872-3268-2-git-send-email-chenxg@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH RFC v4 1/6] qemu-iotests: run qemu with
 -nodefaults
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, mreitz@redhat.com, mimu@linux.vnet.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com

On Thu, 02/05 11:44, Xiao Guang Chen wrote:
> This patch fixes an io test suite issue that was introduced with the
> commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only
> a single "stdio" character device'. The option supresses the creation of
> default devices.
> 
> Reviewed-by: Michael Mueller <mimu@linux.vnet.ibm.com>
> Signed-off-by: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>
> ---
>  tests/qemu-iotests/common        | 1 +
>  tests/qemu-iotests/common.config | 2 +-
>  tests/qemu-iotests/common.qemu   | 2 +-
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
> index 1e556bb..ed26d79 100644
> --- a/tests/qemu-iotests/common
> +++ b/tests/qemu-iotests/common
> @@ -51,6 +51,7 @@ export IMGOPTS=""
>  export CACHEMODE="writeback"
>  export QEMU_IO_OPTIONS=""
>  export CACHEMODE_IS_DEFAULT=true
> +export QEMU_OPTIONS="-nodefaults"
>  
>  for r
>  do
> diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config
> index a1973ad..cff91e1 100644
> --- a/tests/qemu-iotests/common.config
> +++ b/tests/qemu-iotests/common.config
> @@ -103,7 +103,7 @@ if [ -z "$QEMU_NBD_PROG" ]; then
>      export QEMU_NBD_PROG="`set_prog_path qemu-nbd`"
>  fi
>  
> -export QEMU=$QEMU_PROG
> +export QEMU="$QEMU_PROG $QEMU_OPTIONS"
>  export QEMU_IMG=$QEMU_IMG_PROG
>  export QEMU_IO="$QEMU_IO_PROG $QEMU_IO_OPTIONS"
>  export QEMU_NBD=$QEMU_NBD_PROG
> diff --git a/tests/qemu-iotests/common.qemu b/tests/qemu-iotests/common.qemu
> index 8e618b5..e35a797 100644
> --- a/tests/qemu-iotests/common.qemu
> +++ b/tests/qemu-iotests/common.qemu
> @@ -153,7 +153,7 @@ function _launch_qemu()
>      mkfifo "${fifo_out}"
>      mkfifo "${fifo_in}"
>  
> -    "${QEMU}" -nographic -serial none ${comm} -machine accel=qtest "${@}" \
> +    ${QEMU} -nographic -serial none ${comm} -machine accel=qtest "${@}" \

I believe the reason to quote ${QEMU} was allow paths containing whitespaces.
Why not leave the quotes unchanged and add $QEMU_OPTIONS here?

Fam