From: Stefan Hajnoczi <stefanha@gmail.com>
To: John Snow <jsnow@redhat.com>
Cc: famz@redhat.com, mst@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 03/19] qtest/ahci: rename 'Command' to 'CommandHeader'
Date: Thu, 5 Feb 2015 13:06:55 +0000 [thread overview]
Message-ID: <20150205130655.GA17662@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1422999999-25868-4-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Tue, Feb 03, 2015 at 04:46:23PM -0500, John Snow wrote:
> The structure name is a bit of a misnomer; the structure currently named
> command is actually the commandheader. A future patch in this series
> will add an actual "Command" structure, so we'll rename it now before the
> rest of the functions in this series try to use it.
>
> In addition, rename the "b1" and "b2" fields
> to be a unified uint16_t named "flags."
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/ahci-test.c | 8 ++++----
> tests/libqos/ahci.h | 7 +++----
> 2 files changed, 7 insertions(+), 8 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-02-05 13:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 21:46 [Qemu-devel] [PATCH v2 00/19] qtest/ahci: add dma test John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 01/19] libqos/ahci: Add ahci_port_select helper John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 02/19] libqos/ahci: Add ahci_port_clear helper John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 03/19] qtest/ahci: rename 'Command' to 'CommandHeader' John Snow
2015-02-05 13:06 ` Stefan Hajnoczi [this message]
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 04/19] libqos/ahci: Add command header helpers John Snow
2015-02-05 13:17 ` Stefan Hajnoczi
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 05/19] libqos/ahci: Add ahci_port_check_error helper John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 06/19] libqos/ahci: Add ahci_port_check_interrupts helper John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 07/19] libqos/ahci: Add port_check_nonbusy helper John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 08/19] libqos/ahci: Add cmd response sanity check helpers John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 09/19] qtest/ahci: Demagic ahci tests John Snow
2015-02-05 13:22 ` Stefan Hajnoczi
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 10/19] qtest/ahci: add ahci_write_fis John Snow
2015-02-05 13:29 ` Stefan Hajnoczi
2015-02-05 16:19 ` John Snow
2015-02-06 10:41 ` Stefan Hajnoczi
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 11/19] libqos/ahci: Add ide cmd properties John Snow
2015-02-05 13:43 ` Stefan Hajnoczi
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 12/19] libqos/ahci: add ahci command functions John Snow
2015-02-05 13:44 ` Stefan Hajnoczi
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 13/19] libqos/ahci: add ahci command verify John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 14/19] libqos/ahci: add ahci command size setters John Snow
2015-02-05 13:45 ` Stefan Hajnoczi
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 15/19] libqos/ahci: Add ahci_guest_io John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 16/19] libqos/ahci: add ahci_io John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 17/19] libqos/ahci: Add ahci_clean_mem John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 18/19] qtest/ahci: Assert sector size in identify test John Snow
2015-02-03 21:46 ` [Qemu-devel] [PATCH v2 19/19] qtest/ahci: Adding simple dma read-write test John Snow
2015-02-05 13:41 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205130655.GA17662@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).