From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJMNx-0002jo-Dx for qemu-devel@nongnu.org; Thu, 05 Feb 2015 08:22:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJMNs-0006fw-Us for qemu-devel@nongnu.org; Thu, 05 Feb 2015 08:22:21 -0500 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:63834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJMNs-0006eq-OS for qemu-devel@nongnu.org; Thu, 05 Feb 2015 08:22:16 -0500 Received: by mail-wi0-f171.google.com with SMTP id l15so38784346wiw.4 for ; Thu, 05 Feb 2015 05:22:16 -0800 (PST) Date: Thu, 5 Feb 2015 13:22:04 +0000 From: Stefan Hajnoczi Message-ID: <20150205132204.GC17662@stefanha-thinkpad.redhat.com> References: <1422999999-25868-1-git-send-email-jsnow@redhat.com> <1422999999-25868-10-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rQ2U398070+RC21q" Content-Disposition: inline In-Reply-To: <1422999999-25868-10-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 09/19] qtest/ahci: Demagic ahci tests. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: famz@redhat.com, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com --rQ2U398070+RC21q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 03, 2015 at 04:46:29PM -0500, John Snow wrote: > Add human-readable command names and other miscellaneous #defines > to help make the code more readable. >=20 > Some of these definitions are not yet used in this current series, > but for convenience and sanity they have been lumped together here, > as it's more trouble than it is worth in a test suite to hand-pick, > one-by-one, which preprocessor definitions are useful per-each test. >=20 > These definitions include: >=20 > ATA Command Mnemonics > Current expected AHCI sector size > FIS magic bytes > REG_H2D_FIS flags > Command Header flags >=20 > Signed-off-by: John Snow > --- > tests/ahci-test.c | 12 ++++++------ > tests/libqos/ahci.h | 53 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++ > 2 files changed, 59 insertions(+), 6 deletions(-) I have not checked all the constants against the spec, but the patch looks reasonable. Reviewed-by: Stefan Hajnoczi --rQ2U398070+RC21q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU0258AAoJEJykq7OBq3PIvMEIAJgUB3f5z8dlqLsvegDcOs72 HItax09067RWMKe3jLvHN2GEYrGgd8cFYgOJVPUWmsG7fIrndU0SIIlrnn2r7nTJ nPDJolwR1sHBHpkq+haV6sznyVt+oo3/Xr26K+3gqfMQVUPKPJE2fdY9pPIqVAtF x/aOSkxybxFRJ4Ad+BKsSCAiz6oWKwY+24lBYGmeEyp9dMXzwsJNu6ZUPyniHF8E HjIPxNX/pO2JOemM3zWmmIwptidPj4RZbbpAOrajFUl3YUaZ5SWzG96M2ac8b9BV whkxiU1nAM4wC/tAjzizf1ehNCKsqkH9EGxPbM9+ksDfWnaSbpIXNOnRjyfN68g= =VqP6 -----END PGP SIGNATURE----- --rQ2U398070+RC21q--