From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJgRJ-0004XP-Lg for qemu-devel@nongnu.org; Fri, 06 Feb 2015 05:47:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJgQq-0004s7-1w for qemu-devel@nongnu.org; Fri, 06 Feb 2015 05:47:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJgQp-0004rc-NY for qemu-devel@nongnu.org; Fri, 06 Feb 2015 05:46:39 -0500 Date: Fri, 6 Feb 2015 10:46:33 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150206104632.GF2364@work-vm> References: <1422875149-13198-1-git-send-email-liang.z.li@intel.com> <1422875149-13198-7-git-send-email-liang.z.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422875149-13198-7-git-send-email-liang.z.li@intel.com> Subject: Re: [Qemu-devel] [v4 06/13] arch_init: Add and free data struct for decompression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li Cc: quintela@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, Yang Zhang , amit.shah@redhat.com * Liang Li (liang.z.li@intel.com) wrote: > Define the data structure and variables used to do multiple thread > decompression, and add the code to initialize and free them. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Reviewed-by: Dr. David Alan Gilbert > --- > arch_init.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch_init.c b/arch_init.c > index 87c4947..500f299 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -345,7 +345,12 @@ struct CompressParam { > typedef struct CompressParam CompressParam; > > struct DecompressParam { > - /* To be done */ > + bool busy; > + QemuMutex mutex; > + QemuCond cond; > + void *des; > + uint8 *compbuf; > + int len; > }; > typedef struct DecompressParam DecompressParam; > > @@ -1188,6 +1193,9 @@ void migrate_decompress_threads_create(int count) > compressed_data_buf = g_malloc0(compressBound(TARGET_PAGE_SIZE)); > quit_thread = false; > for (i = 0; i < count; i++) { > + qemu_mutex_init(&decomp_param[i].mutex); > + qemu_cond_init(&decomp_param[i].cond); > + decomp_param[i].compbuf = g_malloc0(compressBound(TARGET_PAGE_SIZE)); > qemu_thread_create(decompress_threads + i, "decompress", > do_data_decompress, decomp_param + i, > QEMU_THREAD_JOINABLE); > @@ -1202,6 +1210,9 @@ void migrate_decompress_threads_join(void) > thread_count = migrate_decompress_threads(); > for (i = 0; i < thread_count; i++) { > qemu_thread_join(decompress_threads + i); > + qemu_mutex_destroy(&decomp_param[i].mutex); > + qemu_cond_destroy(&decomp_param[i].cond); > + g_free(decomp_param[i].compbuf); > } > g_free(decompress_threads); > g_free(decomp_param); > -- > 1.9.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK