From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: stefanha@redhat.com, qemu-devel@nongnu.org,
Pavel.Dovgaluk@ispras.ru, freddy77@gmail.com
Subject: Re: [Qemu-devel] [PATCH] rtl8139: simplify timer logic
Date: Fri, 6 Feb 2015 14:04:45 +0000 [thread overview]
Message-ID: <20150206140445.GC18729@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1421765099-26190-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
On Tue, Jan 20, 2015 at 03:44:59PM +0100, Paolo Bonzini wrote:
> Pavel Dovgalyuk reports that TimerExpire and the timer are not restored
> correctly on the receiving end of migration.
>
> It is not clear to me whether this is really the case, but we can take
> the occasion to get rid of the complicated code that computes PCSTimeout
> on the fly upon changes to IntrStatus/IntrMask. Just always keep a
> timer running, it will fire every ~130 seconds at most if the interrupt
> is masked with TimerInt != 0.
>
> This makes rtl8139_set_next_tctr_time idempotent (when the virtual clock
> is stopped between two calls, as is the case during migration).
>
> Tested with Frediano's qtest.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/net/rtl8139.c | 77 ++++++++++++++++++++------------------------------------
> 1 file changed, 27 insertions(+), 50 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-02-06 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 14:44 [Qemu-devel] [PATCH] rtl8139: simplify timer logic Paolo Bonzini
2015-02-06 14:04 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150206140445.GC18729@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=freddy77@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).