From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJjWh-0000G6-28 for qemu-devel@nongnu.org; Fri, 06 Feb 2015 09:04:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJjWd-0002Wl-2C for qemu-devel@nongnu.org; Fri, 06 Feb 2015 09:04:55 -0500 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:51176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJjWc-0002WC-Ru for qemu-devel@nongnu.org; Fri, 06 Feb 2015 09:04:51 -0500 Received: by mail-wi0-f173.google.com with SMTP id r20so2719403wiv.0 for ; Fri, 06 Feb 2015 06:04:50 -0800 (PST) Date: Fri, 6 Feb 2015 14:04:45 +0000 From: Stefan Hajnoczi Message-ID: <20150206140445.GC18729@stefanha-thinkpad.redhat.com> References: <1421765099-26190-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="96YOpH+ONegL0A3E" Content-Disposition: inline In-Reply-To: <1421765099-26190-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] rtl8139: simplify timer logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: stefanha@redhat.com, qemu-devel@nongnu.org, Pavel.Dovgaluk@ispras.ru, freddy77@gmail.com --96YOpH+ONegL0A3E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 20, 2015 at 03:44:59PM +0100, Paolo Bonzini wrote: > Pavel Dovgalyuk reports that TimerExpire and the timer are not restored > correctly on the receiving end of migration. >=20 > It is not clear to me whether this is really the case, but we can take > the occasion to get rid of the complicated code that computes PCSTimeout > on the fly upon changes to IntrStatus/IntrMask. Just always keep a > timer running, it will fire every ~130 seconds at most if the interrupt > is masked with TimerInt !=3D 0. >=20 > This makes rtl8139_set_next_tctr_time idempotent (when the virtual clock > is stopped between two calls, as is the case during migration). >=20 > Tested with Frediano's qtest. >=20 > Signed-off-by: Paolo Bonzini > --- > hw/net/rtl8139.c | 77 ++++++++++++++++++++------------------------------= ------ > 1 file changed, 27 insertions(+), 50 deletions(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan --96YOpH+ONegL0A3E Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU1Mn9AAoJEJykq7OBq3PI0c0H/0iue4gKGjzXNS9S6uAFz1Sy 6VxuBZJiKjS203x8x9NJDEDu9KqUSQ9SDH0waLzsnSK8yFwo3wGWoI7XqLdupUju 1KRiK/I+rXA9OgcvgM+M7VhBVDk+1jx8LpBCJPgDVKmTFKY+c9Zn9ofWflLjQke2 UX7Rflg7qQaBY6npZsCAnOEANV9b5h2MDHpdqOQLFP6Ediyum8IpoXDwwRNVH/uK CrqrlExUUiq8d7hWr8ZWruI4khG5oZlHhjwfWMtHCTDLC0gwfcCY+ikVUxOrdjnJ dLemtnvhVf+r+DOkBkyRYHfvfCtIx6ayHhT5YzOz3IW+0prC2+ZjM8gzTD7rF5k= =2oXd -----END PGP SIGNATURE----- --96YOpH+ONegL0A3E--