From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKPQL-0008JY-SK for qemu-devel@nongnu.org; Sun, 08 Feb 2015 05:49:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKPQI-00066B-90 for qemu-devel@nongnu.org; Sun, 08 Feb 2015 05:49:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKPQI-00065o-1c for qemu-devel@nongnu.org; Sun, 08 Feb 2015 05:49:06 -0500 Date: Sun, 8 Feb 2015 11:48:54 +0100 From: "Michael S. Tsirkin" Message-ID: <20150208104854.GF3185@redhat.com> References: <1423201286-16503-1-git-send-email-tiejun.chen@intel.com> <20150206131446.713805ed.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150206131446.713805ed.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, aliguori@amazon.com, amit.shah@redhat.com, Tiejun Chen On Fri, Feb 06, 2015 at 01:14:46PM +0100, Cornelia Huck wrote: > On Fri, 6 Feb 2015 13:41:26 +0800 > Tiejun Chen wrote: > > > Actually we define these device IDs in virtio standard, so > > we'd better put them into one common place to manage conveniently. > > Here I also add VIRTIO_ID_RESERVE according to virtio spec. > > > > Signed-off-by: Tiejun Chen We really should just write a script to import the headers from the linux kernel. They will need some tweaks to avoid dependencies on linux/types, but this seems easy to do - better than trying to keep things in sync manually. -- MST