qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/5] virtio: increase VIRITO_QUEUE_MAX to 513
Date: Sun, 8 Feb 2015 11:51:01 +0100	[thread overview]
Message-ID: <20150208105101.GG3185@redhat.com> (raw)
In-Reply-To: <1423209253-22222-3-git-send-email-jasowang@redhat.com>

On Fri, Feb 06, 2015 at 03:54:10PM +0800, Jason Wang wrote:
> Recent linux kernel supports up to 256 tap queues. Increase the limit
> to 513 (256 * 2 + 1(ctrl vq)).
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>

We have a bunch of loops over all possible VQ numbers in virtio pci.
Doing this for 1000 VQs when most of them are inactive seems extreme - I
suspect we need a list of active VQs now.

> ---
>  include/hw/virtio/virtio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> index 220c09d..21bb30f 100644
> --- a/include/hw/virtio/virtio.h
> +++ b/include/hw/virtio/virtio.h
> @@ -92,7 +92,7 @@ typedef struct VirtQueueElement
>      struct iovec out_sg[VIRTQUEUE_MAX_SIZE];
>  } VirtQueueElement;
>  
> -#define VIRTIO_QUEUE_MAX 64
> +#define VIRTIO_QUEUE_MAX 513
>  
>  #define VIRTIO_NO_VECTOR 0xffff
>  
> -- 
> 1.9.1

  parent reply	other threads:[~2015-02-08 10:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06  7:54 [Qemu-devel] [PATCH 0/5] Support more virtio queues Jason Wang
2015-02-06  7:54 ` [Qemu-devel] [PATCH 1/5] virtio: rename VIRTIO_PCI_QUEUE_MAX to VIRTIO_QUEUE_MAX Jason Wang
2015-02-06 11:54   ` Cornelia Huck
2015-02-09  5:58     ` Jason Wang
2015-02-06  7:54 ` [Qemu-devel] [PATCH 2/5] virtio: increase VIRITO_QUEUE_MAX to 513 Jason Wang
2015-02-06 16:21   ` Stefan Hajnoczi
2015-02-08 10:51   ` Michael S. Tsirkin [this message]
2015-02-09  6:11     ` Jason Wang
2015-02-06  7:54 ` [Qemu-devel] [PATCH 3/5] virtio-net: fix the upper bound when trying to delete queues Jason Wang
2015-02-06  7:54 ` [Qemu-devel] [PATCH 4/5] pci: remove hard-coded bar size in msix_init_exclusive_bar() Jason Wang
2015-02-06  7:54 ` [Qemu-devel] [PATCH 5/5] virtio-pci: introduce auto_msix_bar_size property Jason Wang
2015-02-06 16:26 ` [Qemu-devel] [PATCH 0/5] Support more virtio queues Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150208105101.GG3185@redhat.com \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).