From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKPSG-0002lu-Es for qemu-devel@nongnu.org; Sun, 08 Feb 2015 05:51:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKPSD-0006lO-6M for qemu-devel@nongnu.org; Sun, 08 Feb 2015 05:51:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKPSC-0006lJ-Vp for qemu-devel@nongnu.org; Sun, 08 Feb 2015 05:51:05 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t18Ap4Kk029429 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sun, 8 Feb 2015 05:51:04 -0500 Date: Sun, 8 Feb 2015 11:51:01 +0100 From: "Michael S. Tsirkin" Message-ID: <20150208105101.GG3185@redhat.com> References: <1423209253-22222-1-git-send-email-jasowang@redhat.com> <1423209253-22222-3-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423209253-22222-3-git-send-email-jasowang@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/5] virtio: increase VIRITO_QUEUE_MAX to 513 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: qemu-devel@nongnu.org On Fri, Feb 06, 2015 at 03:54:10PM +0800, Jason Wang wrote: > Recent linux kernel supports up to 256 tap queues. Increase the limit > to 513 (256 * 2 + 1(ctrl vq)). > > Signed-off-by: Jason Wang We have a bunch of loops over all possible VQ numbers in virtio pci. Doing this for 1000 VQs when most of them are inactive seems extreme - I suspect we need a list of active VQs now. > --- > include/hw/virtio/virtio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > index 220c09d..21bb30f 100644 > --- a/include/hw/virtio/virtio.h > +++ b/include/hw/virtio/virtio.h > @@ -92,7 +92,7 @@ typedef struct VirtQueueElement > struct iovec out_sg[VIRTQUEUE_MAX_SIZE]; > } VirtQueueElement; > > -#define VIRTIO_QUEUE_MAX 64 > +#define VIRTIO_QUEUE_MAX 513 > > #define VIRTIO_NO_VECTOR 0xffff > > -- > 1.9.1