From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL7bh-0008P0-6w for qemu-devel@nongnu.org; Tue, 10 Feb 2015 04:59:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YL7bb-0005Dt-QZ for qemu-devel@nongnu.org; Tue, 10 Feb 2015 04:59:49 -0500 Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:51397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL7bb-0005DT-K9 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 04:59:43 -0500 Received: by mail-wg0-f41.google.com with SMTP id b13so12332067wgh.0 for ; Tue, 10 Feb 2015 01:59:43 -0800 (PST) Date: Tue, 10 Feb 2015 09:59:40 +0000 From: Stefan Hajnoczi Message-ID: <20150210095940.GB9229@stefanha-thinkpad.redhat.com> References: <1418780167-16231-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l76fUT7nc3MelDdI" Content-Disposition: inline In-Reply-To: <1418780167-16231-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com --l76fUT7nc3MelDdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 16, 2014 at 08:35:50PM -0500, John Snow wrote: > This series was written mostly by Paolo Bonzini to do two things: >=20 > 1. Unify the restart callbacks for ISA, AHCI and BMDMA > 2. Ensure we can restart a command after migration >=20 > Many of the early patches only make much sense considering the > end-goal of eliminating BMDMA specific restart code to be shared > with ISA and AHCI codepaths. >=20 > Migration for halted commands is fixed for ISA, PCI and AHCI. > As a consequence, operations halted via rerror=3Dstop or werror=3Dstop > should be able to be successfully migrated and resumed when using > ISA, PCI, or AHCI. >=20 > This series includes tests for ISA and PCI/BMDMA, but does not > yet include tests for AHCI, which require some more qtest work > to be upstreamed first. Regardless, the AHCI tests have been > written and can be observed at: > https://github.com/jnsnow/qemu/commits/ahci-devel-latest >=20 > See "ahci: add migrate dma test" and "ahci-test: add flush migrate test" > for the WIP versions of the AHCI test that I used to exercise this > patchset. >=20 > John Snow (3): > ahci: Migrate IDEStatus > ahci: Recompute cur_cmd on migrate post load > qtest/ide: Test flush / retry for ISA and PCI >=20 > Paolo Bonzini (14): > ide: start extracting ide_restart_dma out of bmdma_restart_dma > ide: prepare to move restart to common code > ide: introduce ide_register_restart_cb > ide: do not use BMDMA in restart callback > ide: pass IDEBus to the restart_cb > ide: move restart callback to common code > ide: remove restart_cb callback > ide: replace set_unit callback with more IDEBus state > ide: place initial state of the current request to IDEBus > ide: migrate initial request state via IDEBus > ide: commonize io_buffer_index initialization > ide: make more functions static > ide: support PIO restart for the ISA controller > ahci: add support for restarting non-queued commands >=20 > hw/ide/ahci.c | 37 +++++++++--------- > hw/ide/atapi.c | 3 +- > hw/ide/cmd646.c | 3 +- > hw/ide/core.c | 109 +++++++++++++++++++++++++++++++++++++++++++++++-= ------ > hw/ide/internal.h | 16 +++++--- > hw/ide/isa.c | 3 +- > hw/ide/macio.c | 6 --- > hw/ide/pci.c | 98 ++++++++---------------------------------------- > hw/ide/pci.h | 12 +++--- > hw/ide/piix.c | 3 +- > hw/ide/via.c | 3 +- > tests/ide-test.c | 20 +++++++--- > 12 files changed, 165 insertions(+), 148 deletions(-) Looks good but please double-check input validation for migrated fields. I pointed out a patch that seems to lack input validation. Stefan --l76fUT7nc3MelDdI Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU2daMAAoJEJykq7OBq3PI/IEH/17hEuF2aDswG5hM+ZrHDZXu vzPiy9a7n+5QizlqgCGXdLMU7q649YGm3EgqaB5KPLGk+w/0jjTqPpaHG//vQMef 7tlMTvbjJpfa0JQar5tUnmzZ6M9S6P+DwQQEj4X2Id07WBNzsRR9qffnTjV46kXA AltAyJxt1x2UfhNfwAB84eVqcLN+62qVvqQwTI6SHuA2yuzor0lqtOpMr+ETtZjV 8Ss5xcW8ntfiHoEcg+4sR32A7P87WG88sejik2UeWSf64UZWZGZg8FeErBN6Xnyy LLbLoF8T4pQhoCPg4n6FbgutTbZvTy3Hjd9FFVH2WThHZU+ufrd9pxbN17kBRCg= =IWbB -----END PGP SIGNATURE----- --l76fUT7nc3MelDdI--