From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLTvW-0005nz-Tb for qemu-devel@nongnu.org; Wed, 11 Feb 2015 04:49:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLTvS-0002tp-Ac for qemu-devel@nongnu.org; Wed, 11 Feb 2015 04:49:46 -0500 Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:35048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLTvS-0002tO-0w for qemu-devel@nongnu.org; Wed, 11 Feb 2015 04:49:42 -0500 Received: by mail-we0-f179.google.com with SMTP id u56so2199298wes.10 for ; Wed, 11 Feb 2015 01:49:41 -0800 (PST) Date: Wed, 11 Feb 2015 09:49:36 +0000 From: Stefan Hajnoczi Message-ID: <20150211094936.GA336@stefanha-thinkpad.redhat.com> References: <1423119261-60904-1-git-send-email-sfeldma@gmail.com> <1423119261-60904-7-git-send-email-sfeldma@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline In-Reply-To: <1423119261-60904-7-git-send-email-sfeldma@gmail.com> Subject: Re: [Qemu-devel] [PATCH v6 06/10] rocker: add new rocker switch device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com Cc: jiri@resnulli.us, roopa@cumulusnetworks.com, john.fastabend@gmail.com, qemu-devel@nongnu.org, dsahern@gmail.com, pbonzini@redhat.com, jasowang@redhat.com --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 04, 2015 at 10:54:17PM -0800, sfeldma@gmail.com wrote: > diff --git a/default-configs/pci.mak b/default-configs/pci.mak > index a186c39..a7f3278 100644 > --- a/default-configs/pci.mak > +++ b/default-configs/pci.mak > @@ -32,3 +32,4 @@ CONFIG_PCI_TESTDEV=3Dy > CONFIG_NVME_PCI=3Dy > CONFIG_SD=3Dy > CONFIG_SDHCI=3Dy > +CONFIG_ROCKER=3Dy > diff --git a/hw/net/Makefile.objs b/hw/net/Makefile.objs > index ea93293..4f8e826 100644 > --- a/hw/net/Makefile.objs > +++ b/hw/net/Makefile.objs > @@ -35,3 +35,6 @@ obj-y +=3D vhost_net.o > =20 > obj-$(CONFIG_ETSEC) +=3D fsl_etsec/etsec.o fsl_etsec/registers.o \ > fsl_etsec/rings.o fsl_etsec/miim.o > + > +common-obj-y +=3D rocker/rocker.o rocker/rocker_fp.o rocker/rocker_desc.= o \ > + rocker/rocker_world.o rocker/rocker_of_dpa.o common-obj-y breaks builds for targets that do not support PCI. This should be common-obj-$(CONFIG_ROCKER) instead. This poses a new problem: when QEMU is built without rocker the QMP/HMP commands fail to link because rocker_find() and friends are missing (they live in rocker.c). There are two options compile out the HMP/QMP commands (see how SPICE does this, e.g. query-spice) or provide stub functions that return an error to the HMP/QMP client when rocker is unavailable. --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU2yWwAAoJEJykq7OBq3PIwN8H/1u42XCMhzEfVwvJmVfwoSQ0 7qRjoMUvcx0mx6LDKdd7e4pI9nX78akq5EfIArAMe8pmwdoufhRANue9lvPMiWNa 2FS67kiYJPQSxosYDurYItu5LeEE8yEISsi3nEa4Z+Dz/rIfGyIlgDFzCbRUXvDY HkstOXNgKHS2hyCyrWNkIN5trTaanH99oxwVv098jDskPEnrsgrXXMZXDcNngKm1 RH6IWzLKqQHpAVBKVTmSDONt6kee2RaKhvdwfHrM8ofsIKM6RNQiAn1EFf6+S/Tg YEUyAzDJ6bd0xIWCgQ+jQSBgZn9vnjB+0hLerywtZOXzTnDBsgYNZatTYp8ndlM= =D0tB -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR--