From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLVtT-0007hL-H0 for qemu-devel@nongnu.org; Wed, 11 Feb 2015 06:55:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLVtQ-0007ll-7Y for qemu-devel@nongnu.org; Wed, 11 Feb 2015 06:55:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLVtP-0007lZ-VP for qemu-devel@nongnu.org; Wed, 11 Feb 2015 06:55:44 -0500 Date: Wed, 11 Feb 2015 17:25:29 +0530 From: Amit Shah Message-ID: <20150211115529.GL17420@grmbl.mre> References: <1423201286-16503-1-git-send-email-tiejun.chen@intel.com> <20150209195742.GA29255@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150209195742.GA29255@redhat.com> Subject: Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, aliguori@amazon.com, cornelia.huck@de.ibm.com, Tiejun Chen On (Mon) 09 Feb 2015 [20:57:42], Michael S. Tsirkin wrote: > On Fri, Feb 06, 2015 at 01:41:26PM +0800, Tiejun Chen wrote: > > Actually we define these device IDs in virtio standard, so > > we'd better put them into one common place to manage conveniently. > > Here I also add VIRTIO_ID_RESERVE according to virtio spec. > > > > Signed-off-by: Tiejun Chen > > So I just posted a script that pulls in headers from > a linux tree, doing minor changes required to > make the headers portable, such as > linux/types.h -> inttypes.h We used to do this for kvm headers earlier.. Anyway I don't feel strongly about it. Cornelia's objection that it doesn't work on non-Linux hosts also holds.. Amit