From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YLWXz-0004yQ-LE
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 07:37:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YLWXu-000591-NB
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 07:37:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49501)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YLWXu-00058x-Fk
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 07:37:34 -0500
Date: Wed, 11 Feb 2015 13:37:24 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150211123724.GE4623@redhat.com>
References: <1423201286-16503-1-git-send-email-tiejun.chen@intel.com>
	<20150209195742.GA29255@redhat.com>
	<20150211115529.GL17420@grmbl.mre>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150211115529.GL17420@grmbl.mre>
Subject: Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, aliguori@amazon.com, cornelia.huck@de.ibm.com, Tiejun Chen <tiejun.chen@intel.com>

On Wed, Feb 11, 2015 at 05:25:29PM +0530, Amit Shah wrote:
> On (Mon) 09 Feb 2015 [20:57:42], Michael S. Tsirkin wrote:
> > On Fri, Feb 06, 2015 at 01:41:26PM +0800, Tiejun Chen wrote:
> > > Actually we define these device IDs in virtio standard, so
> > > we'd better put them into one common place to manage conveniently.
> > > Here I also add VIRTIO_ID_RESERVE according to virtio spec.
> > > 
> > > Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
> > 
> > So I just posted a script that pulls in headers from
> > a linux tree, doing minor changes required to
> > make the headers portable, such as
> > linux/types.h -> inttypes.h
> 
> We used to do this for kvm headers earlier..
> 
> Anyway I don't feel strongly about it.  Cornelia's objection that it
> doesn't work on non-Linux hosts also holds..
> 
> 		Amit

Imported headers clearly can work on non linux hosts.

-- 
MST