Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Feb 11, 2015 at 01:29:53PM +0000, Peter Maydell wrote:
> On 11 February 2015 at 12:33, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Wed, Feb 11, 2015 at 02:12:35AM +0000, Peter Maydell wrote:
> >> On 9 February 2015 at 19:56, Michael S. Tsirkin <mst@redhat.com> wrote:
> >> > +rm -rf "$output/standard-headers/linux"
> >> > +mkdir -p "$output/standard-headers/linux"
> >> > +for f in $tmpdir/include/linux/virtio*h; do
> >> > +    header=$(expr "$f" : '.*/\(.*\)');
> >> > +    sed -e 's/__u\([0-9][0-9]*\)/uint\1_t/g' \
> >> > +        -e 's/linux\/types/inttypes/' \
> >> > +        -e 's/__bitwise__//' \
> >> > +        "$tmpdir/include/linux/$header" > \
> >> > +        "$output/standard-headers/linux/$header";
> >> > +done
> >>
> >> This doesn't seem to be doing anything to fix up
> >> the '__attribute__((packed))' annotations.
> >
> > I don't know - what needs to be fixed up?
> 
> Needs to use the QEMU_PACKED macro.
> 
> -- PMM

Thanks.