From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56472)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YLXym-0006AN-OC
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 09:09:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YLXyj-0003v0-JZ
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 09:09:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38976)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YLXyj-0003uj-Ck
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 09:09:21 -0500
Date: Wed, 11 Feb 2015 15:09:10 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150211140910.GH4623@redhat.com>
References: <1423511512-29208-1-git-send-email-mst@redhat.com>
	<CAFEAcA8QFTWbBZSPjCKzEBBwWZojJL+LDKTPL_F=eCDpDHj=Zw@mail.gmail.com>
	<20150211123343.GC4623@redhat.com>
	<CAFEAcA_M5vZXoKToLNrRQJuZzWibFeL-=8eGaMWfzbPCr1BXcg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_M5vZXoKToLNrRQJuZzWibFeL-=8eGaMWfzbPCr1BXcg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull
	virtio hdrs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, "Chen,
	Tiejun" <tiejun.chen@intel.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Alexander Graf <agraf@suse.de>

On Wed, Feb 11, 2015 at 01:29:53PM +0000, Peter Maydell wrote:
> On 11 February 2015 at 12:33, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Wed, Feb 11, 2015 at 02:12:35AM +0000, Peter Maydell wrote:
> >> On 9 February 2015 at 19:56, Michael S. Tsirkin <mst@redhat.com> wrote:
> >> > +rm -rf "$output/standard-headers/linux"
> >> > +mkdir -p "$output/standard-headers/linux"
> >> > +for f in $tmpdir/include/linux/virtio*h; do
> >> > +    header=$(expr "$f" : '.*/\(.*\)');
> >> > +    sed -e 's/__u\([0-9][0-9]*\)/uint\1_t/g' \
> >> > +        -e 's/linux\/types/inttypes/' \
> >> > +        -e 's/__bitwise__//' \
> >> > +        "$tmpdir/include/linux/$header" > \
> >> > +        "$output/standard-headers/linux/$header";
> >> > +done
> >>
> >> This doesn't seem to be doing anything to fix up
> >> the '__attribute__((packed))' annotations.
> >
> > I don't know - what needs to be fixed up?
> 
> Needs to use the QEMU_PACKED macro.
> 
> -- PMM

Thanks.