From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLaTK-0008RT-27 for qemu-devel@nongnu.org; Wed, 11 Feb 2015 11:49:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLaTG-0002jv-R3 for qemu-devel@nongnu.org; Wed, 11 Feb 2015 11:49:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLaTG-0002jq-Ja for qemu-devel@nongnu.org; Wed, 11 Feb 2015 11:49:02 -0500 Date: Wed, 11 Feb 2015 16:48:54 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150211164853.GF2371@work-vm> References: <1423584999-13946-1-git-send-email-dgilbert@redhat.com> <1423584999-13946-3-git-send-email-dgilbert@redhat.com> <20150210164720.GK400@redhat.com> <54DA3880.2020705@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54DA3880.2020705@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com * Eric Blake (eblake@redhat.com) wrote: > On 02/10/2015 09:47 AM, Daniel P. Berrange wrote: > > On Tue, Feb 10, 2015 at 04:16:38PM +0000, Dr. David Alan Gilbert (git) wrote: > >> From: "Dr. David Alan Gilbert" > >> > >> Once a qemu has been started with -incoming pause the > > s/pause the/pause, the/ > > >> migration can be started by issuing: > >> > >> migrate -u uri > >> > >> Signed-off-by: Dr. David Alan Gilbert > >> --- > > > > Hmm, the 'unpause' codepath doesn't really share anything with the existing > > codepath. Also the URIs for the existing migrate command are not quite the > > same as the URIs for the incoming migrate side. This would suggest to me > > that it might be better to have a separate 'migrate-incoming' command in > > the monitor rather than overload the existing 'migrate' command. > > > > Also having a separate command will make it possible to detect that this > > feature is supported from libvirt, since I don't think QMP introspection > > provides enough info to detect it based on the new arg to existing > > commands. > > Agree, a new command for QMP would be better (it serves as both the new > command to use, and the witness that the '-incoming pause:' command line > works). The HMP 'migrate -u' is just fine, though (it's fine to have a > single HMP command smart enough to call out to two different QMP commands). I've split it out as you all suggested; I made it migrate-incoming and also made an HMP migrate_incoming; although as you say you can merge them, I just find it easier when they match - if you're used to using an HMP command it's easier when you need to find the matching QMP command. Dave > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK