From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56307)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YLbwF-0008Cb-SZ
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 13:23:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YLbwB-0008Ic-Rv
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 13:23:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44691)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YLbwB-0008IW-KZ
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 13:22:59 -0500
Date: Wed, 11 Feb 2015 18:22:53 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20150211182253.GH2371@work-vm>
References: <1423673184-5903-1-git-send-email-dgilbert@redhat.com>
	<1423673184-5903-3-git-send-email-dgilbert@redhat.com>
	<87egpw8g48.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87egpw8g48.fsf@neno.neno>
Subject: Re: [Qemu-devel] [PATCH v2 2/3] Add migrate_incoming
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: liang.z.li@intel.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com

* Juan Quintela (quintela@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > Add migrate_incoming/migrate-incoming to start an incoming
> > migration.
> >
> > Once a qemu has been started with
> >     -incoming pause
> >
> > the migration can be started by issuing:
> >     migrate_incoming uri
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> 
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> 
> > +        .name       = "migrate_incoming",
> > +        .args_type  = "uri:s",
> > +        .params     = "uri",
> > +        .help       = "Unpause an incoming migration from an -incoming pause",
> > +        .mhandler.cmd = hmp_migrate_incoming,
> > +    },
> 
> As you know, I am a funny man, so .....
> 
> (qemu) migrate_incoming paused
> 
> funny, right?

(qemu) migrate_incoming paused
unknown migration protocol: paused
(qemu) migrate_incoming pause
Pausing an already paused incoming migration

Didn't want to let you get away with that :-)

> Not that --incomining in general is well prepared for abuse O:-)

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK