From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLdLg-0002Ii-RA for qemu-devel@nongnu.org; Wed, 11 Feb 2015 14:53:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLdLd-0006pY-LL for qemu-devel@nongnu.org; Wed, 11 Feb 2015 14:53:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLdLd-0006pP-Ci for qemu-devel@nongnu.org; Wed, 11 Feb 2015 14:53:21 -0500 Date: Wed, 11 Feb 2015 20:53:03 +0100 From: "Michael S. Tsirkin" Message-ID: <20150211195303.GI4623@redhat.com> References: <1423201286-16503-1-git-send-email-tiejun.chen@intel.com> <20150206131446.713805ed.cornelia.huck@de.ibm.com> <20150208104854.GF3185@redhat.com> <54D85B3B.3040306@intel.com> <20150209070249.GA11823@redhat.com> <54D85D59.6010209@intel.com> <20150209094720.005b1ff6.cornelia.huck@de.ibm.com> <20150211124129.GF4623@redhat.com> <20150211191022.57dba26a.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150211191022.57dba26a.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, aliguori@amazon.com, amit.shah@redhat.com, "Chen, Tiejun" On Wed, Feb 11, 2015 at 07:10:22PM +0100, Cornelia Huck wrote: > On Wed, 11 Feb 2015 13:41:29 +0100 > "Michael S. Tsirkin" wrote: > > > On Mon, Feb 09, 2015 at 09:47:20AM +0100, Cornelia Huck wrote: > > > > Well, we do need the changes in way more than two places, as every host > > > or guest has to collect the definitions on its own, no? > > > > This has nothing to do with host. > > Hm, but all hosts and all guests need the ids, no? > > > It's just using linux source as main basis for the file > > simply because linux is a higher visibility project than qemu, > > they won't borrow code from us but we can borrow from them. > > It still seems restricting to use Linux as the ultimate source - and > that has nothing to do with visibililty. I'd say pulling from any > project is restricting: Why shouldn't we want to implement something in > qemu that Linux is not (yet) interested in, but other guests are? We can always add such a hypothetical feature in a qemu specific headers. But most things are shared, and manual duplication is bad. > > > (Granted, with > > > Linux and qemu you get most of the users; but it feels a bit strange > > > for a host implementation to collect information from one of its > > > guests. I really think that we should go back to the common root. > > > Didn't we have a BSD-licenced header in the spec?) > > > > virtio linux headers are also BSD licensed intentionally for this > > purpose. > > * This header is BSD licensed so anyone can use the definitions to > > * implement compatible drivers/servers. > > Sure, but I always took this to mean "you can freely copy the > definitions", not "this is the authorative source". virtio spec only has a ring header. We could get it from there but it's easier to get everything from one place I think. -- MST