From: Fam Zheng <famz@redhat.com>
To: Yik Fang <eric.fangyi@huawei.com>
Cc: stefanha@redhat.com, kathy.wangting@huawei.com,
qemu-devel@nongnu.org, boby.chen@huawei.com,
rudy.zhangmin@huawei.com, wu.wubin@huawei.com
Subject: Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value
Date: Thu, 12 Feb 2015 15:38:09 +0800 [thread overview]
Message-ID: <20150212073809.GC32554@ad.nay.redhat.com> (raw)
In-Reply-To: <1423722111-12902-1-git-send-email-eric.fangyi@huawei.com>
On Thu, 02/12 06:21, Yik Fang wrote:
> The value of reply.error should be the type unsigned int.
>
> Signed-off-by: Yik Fang <eric.fangyi@huawei.com>
> ---
> nbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nbd.c b/nbd.c
> index e56afbc1..30e2f3b 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
> default:
> LOG("invalid request type (%u) received", request.type);
> invalid_request:
> - reply.error = -EINVAL;
> + reply.error = EINVAL;
> error_reply:
> if (nbd_co_send_reply(req, &reply, 0) < 0) {
> goto out;
> --
> 1.8.5
>
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2015-02-12 7:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 6:21 [Qemu-devel] [PATCH] nbd: Fix overflow return value Yik Fang
2015-02-12 7:38 ` Fam Zheng [this message]
2015-03-02 1:25 ` Fangyi (C)
2015-03-02 9:48 ` Markus Armbruster
2015-03-09 2:16 ` Yik Fang
2015-03-11 1:27 ` Yik Fang
2015-03-11 11:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212073809.GC32554@ad.nay.redhat.com \
--to=famz@redhat.com \
--cc=boby.chen@huawei.com \
--cc=eric.fangyi@huawei.com \
--cc=kathy.wangting@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=rudy.zhangmin@huawei.com \
--cc=stefanha@redhat.com \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).