From: Kevin Wolf <kwolf@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] block/raw-posix: fix compilation warning on OSX
Date: Thu, 12 Feb 2015 10:52:17 +0100 [thread overview]
Message-ID: <20150212095217.GD4189@noname.str.redhat.com> (raw)
In-Reply-To: <1423719349-4214-1-git-send-email-den@openvz.org>
Am 12.02.2015 um 06:35 hat Denis V. Lunev geschrieben:
> block/raw-posix.c:947:19: warning: unused variable 's' [-Wunused-variable]
> BDRVRawState *s = aiocb->bs->opaque;
>
> This variable is used only when on of the following macros are defined
> CONFIG_XFS, CONFIG_FALLOCATE, CONFIG_FALLOCATE_PUNCH_HOLE or
> CONFIG_FALLOCATE_ZERO_RANGE. Fortunately, CONFIG_FALLOCATE_PUNCH_HOLE
> and CONFIG_FALLOCATE_ZERO_RANGE could be defined only along with
> CONFIG_FALLOCATE. Therefore checking for CONFIG_XFS or CONFIG_FALLOCATE
> would be enough.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Peter Maydell <peter.maydell@linaro.org>
> CC: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2015-02-12 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 5:35 [Qemu-devel] [PATCH 1/1] block/raw-posix: fix compilation warning on OSX Denis V. Lunev
2015-02-12 9:52 ` Kevin Wolf [this message]
2015-02-16 10:23 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212095217.GD4189@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).