From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLqRf-00059F-3Q for qemu-devel@nongnu.org; Thu, 12 Feb 2015 04:52:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLqRb-0003D1-N8 for qemu-devel@nongnu.org; Thu, 12 Feb 2015 04:52:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLqRb-0003CE-Fj for qemu-devel@nongnu.org; Thu, 12 Feb 2015 04:52:23 -0500 Date: Thu, 12 Feb 2015 10:52:17 +0100 From: Kevin Wolf Message-ID: <20150212095217.GD4189@noname.str.redhat.com> References: <1423719349-4214-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423719349-4214-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH 1/1] block/raw-posix: fix compilation warning on OSX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Peter Maydell , qemu-devel@nongnu.org Am 12.02.2015 um 06:35 hat Denis V. Lunev geschrieben: > block/raw-posix.c:947:19: warning: unused variable 's' [-Wunused-variable] > BDRVRawState *s = aiocb->bs->opaque; > > This variable is used only when on of the following macros are defined > CONFIG_XFS, CONFIG_FALLOCATE, CONFIG_FALLOCATE_PUNCH_HOLE or > CONFIG_FALLOCATE_ZERO_RANGE. Fortunately, CONFIG_FALLOCATE_PUNCH_HOLE > and CONFIG_FALLOCATE_ZERO_RANGE could be defined only along with > CONFIG_FALLOCATE. Therefore checking for CONFIG_XFS or CONFIG_FALLOCATE > would be enough. > > Signed-off-by: Denis V. Lunev > CC: Peter Maydell > CC: Kevin Wolf Reviewed-by: Kevin Wolf