From: Jens Freimann <jfrei@linux.vnet.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END
Date: Thu, 12 Feb 2015 15:53:49 +0100 [thread overview]
Message-ID: <20150212145349.GA8212@chuck.boeblingen.de.ibm.com> (raw)
In-Reply-To: <CAFEAcA9VByh8h+ynXfmtoSb2jAfsoKgusqUkKQCcsT_GvY32ew@mail.gmail.com>
On Thu, Feb 12, 2015 at 02:41:15PM +0000, Peter Maydell wrote:
> On 12 February 2015 at 13:08, Jens Freimann <jfrei@linux.vnet.ibm.com> wrote:
> > We have defines for VIRTIO_TRANSPORT_F_START/_END in two places.
> > In include/hw/virtio/virtio.h and in linux-headers/linux/virtio_config.h
> >
> > Since we already get virtio_config.h via update-linux-headers.sh,
> > there's no need to have duplicate defines in QEMU headers files.
> >
> > Let's remove this define from include/hw/virtio/virtio.h
>
> Isn't this going to break compilation on non-linux hosts?
> They don't get linux-headers/ on their include path, so
> our virtio.h is their only source for this define...
Ok, that's a fair point that I didn't think of. What's the correct way
to fix this then? Change our virtio.h manually? In a separate commit
or in the one generated by update-linux-headers (so we don't break bisect)?
Jens
>
> -- PMM
>
next prev parent reply other threads:[~2015-02-12 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 13:08 [Qemu-devel] [PATCH/RFC 0/2] update-linux-headers.sh and virtio Jens Freimann
2015-02-12 13:08 ` [Qemu-devel] [PATCH 1/2] update-linux-headers.sh: also grap virtio_types.h Jens Freimann
2015-02-12 13:08 ` [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END Jens Freimann
2015-02-12 14:41 ` Peter Maydell
2015-02-12 14:53 ` Jens Freimann [this message]
2015-02-19 10:07 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212145349.GA8212@chuck.boeblingen.de.ibm.com \
--to=jfrei@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).