From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLvAO-00055x-RF for qemu-devel@nongnu.org; Thu, 12 Feb 2015 09:55:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLvAJ-0002rL-Ou for qemu-devel@nongnu.org; Thu, 12 Feb 2015 09:54:56 -0500 Received: from e31.co.us.ibm.com ([32.97.110.149]:43074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLvAJ-0002rA-HG for qemu-devel@nongnu.org; Thu, 12 Feb 2015 09:54:51 -0500 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 12 Feb 2015 07:54:50 -0700 Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id D73B719D8042 for ; Thu, 12 Feb 2015 07:45:57 -0700 (MST) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t1CEsgCi22610072 for ; Thu, 12 Feb 2015 07:54:50 -0700 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t1CEsFV3026660 for ; Thu, 12 Feb 2015 07:54:15 -0700 Date: Thu, 12 Feb 2015 15:53:49 +0100 From: Jens Freimann Message-ID: <20150212145349.GA8212@chuck.boeblingen.de.ibm.com> References: <1423746533-45739-1-git-send-email-jfrei@linux.vnet.ibm.com> <1423746533-45739-3-git-send-email-jfrei@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , QEMU Developers , "Michael S. Tsirkin" On Thu, Feb 12, 2015 at 02:41:15PM +0000, Peter Maydell wrote: > On 12 February 2015 at 13:08, Jens Freimann wrote: > > We have defines for VIRTIO_TRANSPORT_F_START/_END in two places. > > In include/hw/virtio/virtio.h and in linux-headers/linux/virtio_config.h > > > > Since we already get virtio_config.h via update-linux-headers.sh, > > there's no need to have duplicate defines in QEMU headers files. > > > > Let's remove this define from include/hw/virtio/virtio.h > > Isn't this going to break compilation on non-linux hosts? > They don't get linux-headers/ on their include path, so > our virtio.h is their only source for this define... Ok, that's a fair point that I didn't think of. What's the correct way to fix this then? Change our virtio.h manually? In a separate commit or in the one generated by update-linux-headers (so we don't break bisect)? Jens > > -- PMM >