From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLvyn-0007eR-6S for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:47:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLvyk-0000cE-1w for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:47:01 -0500 Received: from mail-we0-x22b.google.com ([2a00:1450:400c:c03::22b]:59386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLvyj-0000ZS-Hd for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:46:57 -0500 Received: by mail-we0-f171.google.com with SMTP id p10so10966143wes.2 for ; Thu, 12 Feb 2015 07:46:55 -0800 (PST) Date: Thu, 12 Feb 2015 15:46:53 +0000 From: Stefan Hajnoczi Message-ID: <20150212154653.GB4054@stefanha-thinkpad.redhat.com> References: <1421678101-44779-1-git-send-email-tumanova@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jq0ap7NbKX2Kqbes" Content-Disposition: inline In-Reply-To: <1421678101-44779-1-git-send-email-tumanova@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v6 0/5] Geometry and blocksize detection for backing devices. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ekaterina Tumanova Cc: kwolf@redhat.com, thuth@linux.vnet.ibm.com, borntraeger@de.ibm.com, armbru@redhat.com, Public KVM Mailing List , mihajlov@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com --jq0ap7NbKX2Kqbes Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 19, 2015 at 03:34:56PM +0100, Ekaterina Tumanova wrote: > Updates v5 -> v6: >=20 > Minor Updates according the last review from Stefan Hajnoczi: > 1. Do not change the flow of code, factored out of raw_probe_alignment. > 2. added #ifdef __linux__ in 2 places of raw-posix.c, mentioned by review= er. > 3. adjusted the comment hdev_probe_geometry according suggestment. > 4. use bdrv_nb_sectors(bs) instead of bs->total_sectors. > 5. do not discard error blk_probe_blocksizes(). now has rc. > 6. put the 512-byte default blocksize value in blkconf_blocksizes. > 7. drop the default parameter from the DEFINE_PROP_BLOCKSIZE() macro. Unfortunately this series breaks "make check" so it cannot be merged: GTESTER check-qtest-x86_64 qemu-system-x86_64: logical_block_size must be 512 for IDE qemu-system-x86_64: Device initialization failed. qemu-system-x86_64: Initialization of device ide-cd failed Broken pipe GTester: last random seed: R02S942fac7e56eff09e8ab7a7f7fecf847e --jq0ap7NbKX2Kqbes Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU3MrtAAoJEJykq7OBq3PIXDQH/0U31mt/gZ/3uDX/y92sQP+i oFRvVQsfGAyYovcUV/XSuontYbSElpeCWfco++McQQTZfTmu4NuH/6vgH7CYBWAE oQ4CVmMgUshU8qXNxQqPTNH51jEeWnBsfw4hQDKhkPd7xlZLHKQDS6ts/PQO5kHW QFLLynKzMdGFMT3VdvslqxsTiPIDxcUAOK6uEeYx/OZuodRfsfkr3NSQEHwJVZ2c j9iyUHmJtskIsmkMOkWeu9T3FIZpm8a95rEIb3REVjzvN7/p3AhjeNo2jDBr926u aFeiNGq3nrEtWuztWFd0sDIKG+IAleaoXYijULlXcB+m0wyNZmA4DTtFfv8oxNM= =5bg5 -----END PGP SIGNATURE----- --jq0ap7NbKX2Kqbes--