From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLw3M-00019W-SQ for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:51:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLw3J-0002Wy-Lr for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:51:44 -0500 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:49564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLw3J-0002Wh-BP for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:51:41 -0500 Received: by mail-wg0-f52.google.com with SMTP id x12so1109371wgg.11 for ; Thu, 12 Feb 2015 07:51:40 -0800 (PST) Date: Thu, 12 Feb 2015 15:51:37 +0000 From: Stefan Hajnoczi Message-ID: <20150212155137.GC4054@stefanha-thinkpad.redhat.com> References: <1421698563-6977-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7qSK/uQB79J36Y4o" Content-Disposition: inline In-Reply-To: <1421698563-6977-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/15] ahci-test preliminary refactoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, marc.mari.barcelo@gmail.com, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com --7qSK/uQB79J36Y4o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 19, 2015 at 03:15:48PM -0500, John Snow wrote: > This series aims to do two main things: >=20 > (1) Eliminate global state out of the ahci-test file so that > the tests are more functional. This will allow me to write > migration tests more easily. These tests are already written > and will be submitted upstream after these refactor series. >=20 > (2) With global state removed from ahci-test, factor out functions > that would be useful to manipulate ahci devices into libqos/ahci.o, > to allow other testwriters to capitalize on the functional > refactoring. >=20 > So, as an overview, we do a few things: >=20 > - Clean up the malloc interface to have a clear pc-specific interface > that uses an architecture independent core. >=20 > - Add some new structures to help keep track of AHCI and libqos state. >=20 > - Rewrite existing AHCI helpers and routines to use the new structures > and helper routines. >=20 > - Excise any commonly valuable code to libqos/ahci.h and libqos/ahci.c. >=20 > This series therefore introduces no new functionality itself, but I was > trying to keep the series small and reviewable. The real necessity here > in jumbling malloc and ahci functions around is to create a functional > interface that can be bundled into a single structure to help facilitate > migration testing inside of qtests, for which I intend to export to all > of qtests to be re-used for other tests. >=20 > From this point forward, the churn to my AHCI refactor series should be > significantly reduced and more pleasant to read. >=20 > Thanks, > John. >=20 > V2: > - #6 Made QGuestAllocator object opaque, in a new patch. > - Created page_size setter method. > - #7 Renamed "QOSOperations" to "QOSOps" and added Paolo's R-b. > - #12 Dropped GCC attributes from static inline helpers (ahci.h) > - #15 Adjusted assertion to not compare void ptr to int 0 > - #15 Share ahci.o with libqos-obj-pc-y instead of only ahci-test > * ahci.o is pc-only for now. >=20 > John Snow (15): > libqos: Split apart pc_alloc_init > qtest/ahci: Create ahci.h > libqos: create libqos.c > libqos: add qtest_vboot > libqos: add alloc_init_flags > libqos: Update QGuestAllocator to be opaque > libqos: add pc specific interface > qtest/ahci: Store hba_base in AHCIQState > qtest/ahci: finalize AHCIQState consolidation > qtest/ahci: remove pcibus global > qtest/ahci: remove guest_malloc global > libqos/ahci: Functional register helpers > qtest/ahci: remove getter/setter macros > qtest/ahci: Bookmark FB and CLB pointers > libqos/ahci: create libqos/ahci.c >=20 > tests/Makefile | 5 +- > tests/ahci-test.c | 894 ++++++++---------------------------------= ------ > tests/libqos/ahci.c | 269 ++++++++++++++ > tests/libqos/ahci.h | 435 +++++++++++++++++++++++ > tests/libqos/libqos-pc.c | 24 ++ > tests/libqos/libqos-pc.h | 9 + > tests/libqos/libqos.c | 63 ++++ > tests/libqos/libqos.h | 33 ++ > tests/libqos/malloc-pc.c | 20 +- > tests/libqos/malloc.c | 86 ++++- > tests/libqos/malloc.h | 25 +- > 11 files changed, 1068 insertions(+), 795 deletions(-) > create mode 100644 tests/libqos/ahci.c > create mode 100644 tests/libqos/ahci.h > create mode 100644 tests/libqos/libqos-pc.c > create mode 100644 tests/libqos/libqos-pc.h > create mode 100644 tests/libqos/libqos.c > create mode 100644 tests/libqos/libqos.h >=20 > --=20 > 1.9.3 >=20 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --7qSK/uQB79J36Y4o Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU3MwJAAoJEJykq7OBq3PIUaYH/jNJWJkOKI277YGLCbG0E5HV 4BodjZylIG6yiGs7k6zl6w2V111V6RS869Uwbwruo9wI27bIJUuasn4+v86WbwvE vFwQ9h9Jjjz/eR29lE4Tq/DkraGVF0SSPVDVnLTb/4s+05tixCESOP+kVzRQiZAq /7JYc8r+XoE/WSCYe37jtZDHIJiJv7FBmLwiLp93Xin5PqcQ+gSZ2Tj78o5M3UPb JF7lkl1BNtW7g20YMtXQwD9u+L/yjLH+qtUPPdlOyBET98AnQYFZcxDjLPTzhH/P 4ylRCQ9Ljh0WIyo+xSilEQh6kTJxZjUgPEzzZaFlBa6CUf1tcSUrq0WsjETww1w= =4haQ -----END PGP SIGNATURE----- --7qSK/uQB79J36Y4o--