qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 0/5] block: Add a qemu-iotests case for IO throttling
Date: Thu, 12 Feb 2015 16:50:16 +0000	[thread overview]
Message-ID: <20150212165016.GE4054@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1422586186-9925-1-git-send-email-famz@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

On Fri, Jan 30, 2015 at 10:49:41AM +0800, Fam Zheng wrote:
> v7: Remove any "{iops,bps}_max" in 093 completely. (Max)
> 
> v6: Less resource demanding patch 5. (Max)
>     Add rev-by of Max to other patches.
> 
> v5: Rebase and improve the test. Please review again.
> 
>     Patch dependencies:
> 
>     This test depends on the qtest timer fix to run correctly.
>     http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01865.html
> 
>     Also depends on the os check fix to run at all:
>     http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01848.html
> 
> Original cover letter
> ---------------------
> 
> There is a change in qemu-io sub-commands "aio_read" and "aio_write", which
> makes the aio requests accounted and the statistics reflected in blockstats.
> 
> Note that IO throttling implementation allows overcommiting of requests, so the
> actual IO happened in a time unit may be a bit larger than given limits. In the
> test case, the stats numbers are compared with a 10% error tolerance, to make
> room for such flexibility in order to improve determinism.

Tried to merge this but unfortunately it hangs using 100% CPU:

  $ cd tests/qemu-iotests
  $ ./check 093

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

  parent reply	other threads:[~2015-02-12 16:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30  2:49 [Qemu-devel] [PATCH v7 0/5] block: Add a qemu-iotests case for IO throttling Fam Zheng
2015-01-30  2:49 ` [Qemu-devel] [PATCH v7 1/5] qemu-io: Account IO by aio_read and aio_write Fam Zheng
2015-01-30  2:49 ` [Qemu-devel] [PATCH v7 2/5] qtest: Add scripts/qtest.py Fam Zheng
2015-01-30  2:49 ` [Qemu-devel] [PATCH v7 3/5] qemu-iotests: Add VM method qtest() to iotests.py Fam Zheng
2015-01-30  2:49 ` [Qemu-devel] [PATCH v7 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp Fam Zheng
2015-01-30  2:49 ` [Qemu-devel] [PATCH v7 5/5] qemu-iotests: Add 093 for IO throttling Fam Zheng
2015-01-30 15:30   ` Max Reitz
2015-02-12 16:50 ` Stefan Hajnoczi [this message]
2015-02-13  2:55   ` [Qemu-devel] [PATCH v7 0/5] block: Add a qemu-iotests case " Fam Zheng
2015-02-13 10:01 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150212165016.GE4054@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).