From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM6QC-0006rj-Rw for qemu-devel@nongnu.org; Thu, 12 Feb 2015 21:56:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YM6Q7-0005mh-Un for qemu-devel@nongnu.org; Thu, 12 Feb 2015 21:56:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM6Q7-0005ma-LH for qemu-devel@nongnu.org; Thu, 12 Feb 2015 21:55:55 -0500 Date: Fri, 13 Feb 2015 10:55:50 +0800 From: Fam Zheng Message-ID: <20150213025550.GE20581@ad.nay.redhat.com> References: <1422586186-9925-1-git-send-email-famz@redhat.com> <20150212165016.GE4054@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150212165016.GE4054@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 0/5] block: Add a qemu-iotests case for IO throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz On Thu, 02/12 16:50, Stefan Hajnoczi wrote: > On Fri, Jan 30, 2015 at 10:49:41AM +0800, Fam Zheng wrote: > > v7: Remove any "{iops,bps}_max" in 093 completely. (Max) > > > > v6: Less resource demanding patch 5. (Max) > > Add rev-by of Max to other patches. > > > > v5: Rebase and improve the test. Please review again. > > > > Patch dependencies: > > > > This test depends on the qtest timer fix to run correctly. > > http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01865.html > > > > Also depends on the os check fix to run at all: > > http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01848.html > > > > Original cover letter > > --------------------- > > > > There is a change in qemu-io sub-commands "aio_read" and "aio_write", which > > makes the aio requests accounted and the statistics reflected in blockstats. > > > > Note that IO throttling implementation allows overcommiting of requests, so the > > actual IO happened in a time unit may be a bit larger than given limits. In the > > test case, the stats numbers are compared with a 10% error tolerance, to make > > room for such flexibility in order to improve determinism. > > Tried to merge this but unfortunately it hangs using 100% CPU: > > $ cd tests/qemu-iotests > $ ./check 093 Could you apply this as a dependency? http://lists.gnu.org/archive/html/qemu-stable/2015-01/msg00134.html (sorry, I forgot to update the pointer in cover letter) Fam