From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM7GV-0001gZ-Kg for qemu-devel@nongnu.org; Thu, 12 Feb 2015 22:50:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YM7GS-00052i-7L for qemu-devel@nongnu.org; Thu, 12 Feb 2015 22:50:03 -0500 Received: from mail-ie0-f172.google.com ([209.85.223.172]:45032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM7GS-00052S-3M for qemu-devel@nongnu.org; Thu, 12 Feb 2015 22:50:00 -0500 Received: by iecar1 with SMTP id ar1so16956611iec.11 for ; Thu, 12 Feb 2015 19:49:59 -0800 (PST) Date: Fri, 13 Feb 2015 11:49:54 +0800 From: Liu Yuan Message-ID: <20150213034954.GA21936@ubuntu-trusty> References: <87pp9f1b61.fsf@blackfin.pond.sub.org> <1423799142-21893-1-git-send-email-namei.unix@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423799142-21893-1-git-send-email-namei.unix@gmail.com> Subject: Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, armbru@redhat.com Cc: kwolf@redhat.com, sheepdog@lists.wpkg.org, Stefan Hajnoczi On Fri, Feb 13, 2015 at 11:45:42AM +0800, Liu Yuan wrote: > From: Liu Yuan > > These functions mix up -1 and -errno in return values and would might cause > trouble error handling in the call chain. > > This patch let them return -errno and add some comments. > > Reported-by: Markus Armbruster > Signed-off-by: Liu Yuan Cc Kevin and Stefan