From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMCpf-0007JG-Rx for qemu-devel@nongnu.org; Fri, 13 Feb 2015 04:46:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMCpb-0002Fz-Po for qemu-devel@nongnu.org; Fri, 13 Feb 2015 04:46:43 -0500 Date: Fri, 13 Feb 2015 09:46:33 +0000 From: Stefan Hajnoczi Message-ID: <20150213094633.GA17753@stefanha-thinkpad.redhat.com> References: <1421661103-29153-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE" Content-Disposition: inline In-Reply-To: <1421661103-29153-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qtest: Fix deadloop by running main loop AIO context's timers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Paolo Bonzini , qemu-devel@nongnu.org, qemu-stable@nongnu.org --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 19, 2015 at 05:51:43PM +0800, Fam Zheng wrote: > qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't > forget aio timer list groups. >=20 > Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all > the timergroups of this clock type, including aio tlg, but we don't fire > them, so they are never cleared, which makes a dead loop. >=20 > For example, this function hangs when trying to drive throttled block > request queue with qtest clock_step. >=20 > Signed-off-by: Fam Zheng >=20 > --- > v2: Only run QEMU_CLOCK_VIRTUAL events. (Paolo). > --- > cpus.c | 4 ++++ > 1 file changed, 4 insertions(+) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU3cf5AAoJEJykq7OBq3PIJCAH/RjQs+QE6eNGNmKv4I98c/sE hHGUBF2QZL8iOIon2G0NSU+Zt9PYJavyB2BrNyG8gpQxOvndjzMItrYIAm9aNms4 nqtmSgSzwYFAUTbEqG1iIM0sXsEk6v7hFtZLB/oIb+8Qru9rOceAqVeMECoHvR5n jPYQ0aAdaOHplv5h6zzZBZSTk3eJJ8LU2cW2sR1mKacFVT5xGz6Hc0Qmxkz4OE4H Cg72+L/xmz1VLAqxKre1xmxnZ5+IDR+Xdbnw7r/FxCqa7EogJoZxxbdzZ+TpuYy0 jcsensEAE21mvrGA2uHX/uudJwa8854Hh1N4Q0uANTQDuGw/B1rKMCJ7glCJ7ec= =MpF0 -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE--