From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMD41-0003Tt-Pl for qemu-devel@nongnu.org; Fri, 13 Feb 2015 05:01:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMD3x-0006qg-MI for qemu-devel@nongnu.org; Fri, 13 Feb 2015 05:01:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMD3x-0006qT-FD for qemu-devel@nongnu.org; Fri, 13 Feb 2015 05:01:29 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1DA1R91000354 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 13 Feb 2015 05:01:28 -0500 Date: Fri, 13 Feb 2015 10:01:25 +0000 From: Stefan Hajnoczi Message-ID: <20150213100125.GD17753@stefanha-thinkpad.redhat.com> References: <1422586186-9925-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Xm/fll+QQv+hsKip" Content-Disposition: inline In-Reply-To: <1422586186-9925-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 0/5] block: Add a qemu-iotests case for IO throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, Max Reitz --Xm/fll+QQv+hsKip Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 30, 2015 at 10:49:41AM +0800, Fam Zheng wrote: > v7: Remove any "{iops,bps}_max" in 093 completely. (Max) >=20 > v6: Less resource demanding patch 5. (Max) > Add rev-by of Max to other patches. >=20 > v5: Rebase and improve the test. Please review again. >=20 > Patch dependencies: >=20 > This test depends on the qtest timer fix to run correctly. > http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01865.html >=20 > Also depends on the os check fix to run at all: > http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01848.html >=20 > Original cover letter > --------------------- >=20 > There is a change in qemu-io sub-commands "aio_read" and "aio_write", whi= ch > makes the aio requests accounted and the statistics reflected in blocksta= ts. >=20 > Note that IO throttling implementation allows overcommiting of requests, = so the > actual IO happened in a time unit may be a bit larger than given limits. = In the > test case, the stats numbers are compared with a 10% error tolerance, to = make > room for such flexibility in order to improve determinism. >=20 > Fam >=20 >=20 > Fam Zheng (5): > qemu-io: Account IO by aio_read and aio_write > qtest: Add scripts/qtest.py > qemu-iotests: Add VM method qtest() to iotests.py > qemu-iotests: Allow caller to disable underscore convertion for qmp > qemu-iotests: Add 093 for IO throttling >=20 > qemu-io-cmds.c | 11 ++++ > scripts/qtest.py | 71 ++++++++++++++++++++++++++ > tests/qemu-iotests/093 | 114 ++++++++++++++++++++++++++++++++++++= ++++++ > tests/qemu-iotests/093.out | 5 ++ > tests/qemu-iotests/group | 1 + > tests/qemu-iotests/iotests.py | 23 +++++++-- > 6 files changed, 221 insertions(+), 4 deletions(-) > create mode 100644 scripts/qtest.py > create mode 100755 tests/qemu-iotests/093 > create mode 100644 tests/qemu-iotests/093.out >=20 > --=20 > 1.9.3 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --Xm/fll+QQv+hsKip Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU3ct1AAoJEJykq7OBq3PIXdwH/3QRCW/XXWvGGpD5rSUfjMOv FCPisYSBPSqVNCS2LSG2iTV1YnOjym90K3l8ghrVKClvXyYuQVnjHUrP7k8E8Su0 wkCKuKuftGAnPoWMcqzUjI4SLNR/lzDmYRMlTyiqilJxWDvrRN+lMo4CBNce+0yu sHYRSxKH6uhzwwZEs1nALOBWRyspCD64Oi3Ozw4cMV0XoCCuReYfRuL0vy8lAwEQ K3eQk06INZgqP8Md2it9bRaPahzwT1H52WVOi2ysNZyAhUTlooZtrSG8HACtlZuk jgwvnBzhTOL6ILnx4/oaVpFTT2wJLdfn8690QEexgPPRZnRLbW/1cVJAyLI8acI= =xnaM -----END PGP SIGNATURE----- --Xm/fll+QQv+hsKip--