From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMFph-0003L7-2G for qemu-devel@nongnu.org; Fri, 13 Feb 2015 07:58:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMFpd-0002lJ-RG for qemu-devel@nongnu.org; Fri, 13 Feb 2015 07:58:57 -0500 Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:62208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMFpd-0002lF-Kd for qemu-devel@nongnu.org; Fri, 13 Feb 2015 07:58:53 -0500 Received: by mail-wg0-f46.google.com with SMTP id a1so16521674wgh.5 for ; Fri, 13 Feb 2015 04:58:52 -0800 (PST) Date: Fri, 13 Feb 2015 12:58:50 +0000 From: Stefan Hajnoczi Message-ID: <20150213125850.GD21976@stefanha-thinkpad.redhat.com> References: <1423162705-32065-1-git-send-email-mreitz@redhat.com> <1423162705-32065-4-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GpGaEY17fSl8rd50" Content-Disposition: inline In-Reply-To: <1423162705-32065-4-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 03/16] block: Add Error parameter to bdrv_find_protocol() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --GpGaEY17fSl8rd50 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 05, 2015 at 01:58:12PM -0500, Max Reitz wrote: > The argument given to bdrv_find_protocol() is just a file name, which > makes it difficult for the caller to reconstruct what protocol > bdrv_find_protocol() was hoping to find. This patch adds an Error > parameter to that function to solve this issue. >=20 > Suggested-by: Eric Blake > Signed-off-by: Max Reitz > --- > block.c | 14 +++++++------- > block/sheepdog.c | 2 +- > include/block/block.h | 3 ++- > qemu-img.c | 11 +++++++---- > tests/qemu-iotests/051.out | 4 ++-- > 5 files changed, 19 insertions(+), 15 deletions(-) Reviewed-by: Stefan Hajnoczi --GpGaEY17fSl8rd50 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU3fUKAAoJEJykq7OBq3PIf2YH/AxK4R2Z7nB5XDjt8Bw0fOOR ZhHGtWgUom3kaKBCGJTJi9eIXfXjRf+zL1KSyvwuqTo05bG5ITCtpURVVL6E3uD6 sSPVRmdbojTo8BNJ5xrr84YcUCK2ceNbsnuqUP3ijx/pyO79Ag4CffQuQE/QCbO4 rzkDIq+KEBXNQCkWUrU93Jw0Q7YtBt9dXb9Ub1FRisHjy8WXmg7Mvb3VSvIuOfeD moOKAF3OwTJ4blWSu2vxmEvme0RaOUENPcgNvZApgqQzT3Em8EsqpN+w8S+B2jvY 3n+lWHHmNrRAlsrUtcGwWRUXYd2Q5r2Cqzd4VOSmg4J/Ji3GjceuiFFRc3U3OUo= =VRKe -----END PGP SIGNATURE----- --GpGaEY17fSl8rd50--