From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMP7Y-0005bE-QF for qemu-devel@nongnu.org; Fri, 13 Feb 2015 17:54:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMP7V-0001v9-II for qemu-devel@nongnu.org; Fri, 13 Feb 2015 17:54:00 -0500 Received: from ozlabs.org ([103.22.144.67]:36941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMP7V-0001uy-6r for qemu-devel@nongnu.org; Fri, 13 Feb 2015 17:53:57 -0500 Date: Sat, 14 Feb 2015 09:54:21 +1100 From: David Gibson Message-ID: <20150213225421.GB30518@voom.redhat.com> References: <87a90hoiup.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7" Content-Disposition: inline In-Reply-To: <87a90hoiup.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org --GRPZ8SYKNexpdSJ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 13, 2015 at 05:51:26PM +0100, Markus Armbruster wrote: > Commit 79ca616 "pci: Cleanup configuration for pci-hotplug.c" (June > 2013, released in v1.6.0) made linking pci-hotplug-old.o conditional on > make variable CONFIG_PCI_HOTPLUG_OLD, and the actual monitor commands > conditional on preprocessor macro CONFIG_PCI_HOTPLUG_OLD. Where is that > macro defined? >=20 > In my local build: nowhere. The two commands are not available. >=20 > Am I doing something wrong, or have the commands been gone for five > major releases already? >=20 > If the latter, I think we can safely drop them now :) So AFAICT, CONFIG_PCI_HOTPLUG_OLD is still defined for x86 targets: $ git grep PCI_HOTPLUG_OLD default-configs/i386-softmmu.mak:CONFIG_PCI_HOTPLUG_OLD=3Dy default-configs/x86_64-softmmu.mak:CONFIG_PCI_HOTPLUG_OLD=3Dy =2E.. I believe the reasoning was that for other targets, pci_add/del were never properly supported and we should go directly to device_add/del instead. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --GRPZ8SYKNexpdSJ7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU3oCdAAoJEGw4ysog2bOSOEQP/2Jx0cyqW/rv4HccM8dHg/kA hGg2dtYc9ecCtesfowuTCpDplpccDhynhLQ4noN9O3zIcLWgYNKwQX7OIOthlYym OyKSAlo0B55s+pmVfKJa7czPEtNQ1mnZ5ajG3JOnfp0cvppUja9Lgikkpz6k18M9 gvPLC9v9F69W1NWy3x4w/RbSi6u18i9Q6OmxfJssPybarG5IJ3qvUK2K3Y2cRK8c W/18bdtS1DOhM602SorCKT+DcYyXBdZIjvk934ZI5DOu3ZMcbZDNG3MnMnwswFFg bjCuNa7oLl8SGfJsOSGtzzQtX+detiSijfpCssLxC6VxyuvpJRcDPrLZVbzd+r/2 sBCVBVqMYfWjZlq8EFblJbT8akUy6yJsxG0VeIT6QNVP/ijEeS7jdUZ2lgQ0oq7Q /vab3s1tbLoRmD4vGedgiIz1dGRPZpCxS42J+vufJoU3CxL4r/09vBgDzK1IVelJ svQRII45n0TMpAzWvMWE4B+FWx/xq6y+m3nHh0grp4hZ2N9S73v1Qi+4cleOEwDh 7FJ4uPFF13fLNMU1AIhVIeAtN2q0WQGh2v/cEwQtWPbe84ajxsjSbBpCbdxor8cO wzpTTS5URRziABLerJEpu7lAAQ1PcIwEMUfoGZTDUsleyixkLVT4eLrFTDDFztTe fsi0lly/k2hYsPbZRnwh =Hung -----END PGP SIGNATURE----- --GRPZ8SYKNexpdSJ7--