From: David Gibson <david@gibson.dropbear.id.au>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?
Date: Sun, 15 Feb 2015 14:02:31 +1100 [thread overview]
Message-ID: <20150215030231.GC30518@voom.redhat.com> (raw)
In-Reply-To: <54DF4B6F.9010301@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Sat, Feb 14, 2015 at 02:19:43PM +0100, Paolo Bonzini wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
>
> On 13/02/2015 23:54, David Gibson wrote:
> > So AFAICT, CONFIG_PCI_HOTPLUG_OLD is still defined for x86
> > targets:
> >
> > $ git grep PCI_HOTPLUG_OLD
> > default-configs/i386-softmmu.mak:CONFIG_PCI_HOTPLUG_OLD=y
> > default-configs/x86_64-softmmu.mak:CONFIG_PCI_HOTPLUG_OLD=y ...
>
> But these symbols do not become preprocessor macros...
Godammit. Have I mentioned lately how much it pisses me off that we
have various config symbols and it's never clear which ones make it
into C and which are only in make.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-15 3:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 16:51 [Qemu-devel] Did we lose monitor commands pci_add, pci_del? Markus Armbruster
2015-02-13 22:54 ` David Gibson
2015-02-14 13:19 ` Paolo Bonzini
2015-02-15 3:02 ` David Gibson [this message]
2015-02-15 11:12 ` Peter Maydell
2015-02-16 7:57 ` Markus Armbruster
2015-02-16 10:06 ` Michael Tokarev
2015-02-16 8:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150215030231.GC30518@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).