From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41988)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YMxcO-0005P0-6D
	for qemu-devel@nongnu.org; Sun, 15 Feb 2015 06:44:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YMxcJ-0002Dj-7S
	for qemu-devel@nongnu.org; Sun, 15 Feb 2015 06:44:07 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58129)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YMxcJ-0002DT-17
	for qemu-devel@nongnu.org; Sun, 15 Feb 2015 06:44:03 -0500
Date: Sun, 15 Feb 2015 12:43:51 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150215114351.GA10792@redhat.com>
References: <1423999136-17320-1-git-send-email-mst@redhat.com>
	<CAFEAcA_Sw1u3tzRC4jr8JVf7yn2DQUUawNk1+MQD1R11SU2Jnw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_Sw1u3tzRC4jr8JVf7yn2DQUUawNk1+MQD1R11SU2Jnw@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 00/17] virtio: pull headers from linux
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, "Chen,
	Tiejun" <tiejun.chen@intel.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Alexander Graf <agraf@suse.de>

On Sun, Feb 15, 2015 at 11:41:03AM +0000, Peter Maydell wrote:
> On 15 February 2015 at 11:38, Michael S. Tsirkin <mst@redhat.com> wrote:
> > This reuses virtio headers from files exported by linux.
> > The current situation is quite messy: for example we
> > have multiple copies of the virtio net packet structure,
> > and the virtio ring structure.
> > We already use some of them for linux-specific code,
> > reusing more widely gets rid of code duplication.
> >
> > One of the reasons we didn't do this previously
> > was portability considerations: this patchset addresses
> > this by fixing up headers in question - turns out to
> > be easy to do since they are already quite portable.
> 
> > Lightly tested on x86.
> 
> Did you test on Windows and OSX, or do you need somebody
> to do that?
> 
> -- PMM

Thanks for the reminder - forgot to mention that :(
Tested on linux only, with windows and linux guests.
Needs windows, osx host testing.

-- 
MST