From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@amazon.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Stefan Hajnoczi <stefanha@redhat.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
"Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers
Date: Mon, 16 Feb 2015 12:36:18 +0100 [thread overview]
Message-ID: <20150216113618.GB20667@redhat.com> (raw)
In-Reply-To: <54E1B8B0.5060705@redhat.com>
On Mon, Feb 16, 2015 at 10:30:24AM +0100, Paolo Bonzini wrote:
>
>
> On 15/02/2015 12:39, Michael S. Tsirkin wrote:
> > Drop duplicated code.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > include/hw/virtio/virtio-scsi.h | 120 +++-------------------------------------
> > hw/scsi/virtio-scsi.c | 1 +
> > 2 files changed, 10 insertions(+), 111 deletions(-)
> >
> > diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> > index bf17cc9..9bcda7e 100644
> > --- a/include/hw/virtio/virtio-scsi.h
> > +++ b/include/hw/virtio/virtio-scsi.h
> > @@ -14,6 +14,7 @@
> > #ifndef _QEMU_VIRTIO_SCSI_H
> > #define _QEMU_VIRTIO_SCSI_H
> >
> > +#include "standard-headers/sys/virtio_scsi.h"
>
> Why sys/? It's linux/, let's keep it linux/.
>
> Paolo
Peter requested this change: he felt having portable
headers under linux/ is confusing:
http://mid.gmane.org/CAFEAcA8QFTWbBZSPjCKzEBBwWZojJL+LDKTPL_F=eCDpDHj=Zw@mail.gmail.com
Makes sense?
--
MST
next prev parent reply other threads:[~2015-02-16 11:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 11:38 [Qemu-devel] [PATCH v2 00/17] virtio: pull headers from linux Michael S. Tsirkin
2015-02-15 11:38 ` [Qemu-devel] [PATCH v2 01/17] scripts/update-linux-headers.sh: pull virtio hdrs Michael S. Tsirkin
2015-02-16 14:27 ` Thomas Huth
2015-02-15 11:38 ` [Qemu-devel] [PATCH v2 02/17] include: import virtio headers from linux 4.0 Michael S. Tsirkin
2015-02-16 16:03 ` Thomas Huth
2015-02-16 16:13 ` Michael S. Tsirkin
2015-02-15 11:38 ` [Qemu-devel] [PATCH v2 03/17] virtio: use standard virtio_ring.h Michael S. Tsirkin
2015-02-15 11:38 ` [Qemu-devel] [PATCH v2 04/17] virtio: use standard-headers Michael S. Tsirkin
2015-02-15 11:38 ` [Qemu-devel] [PATCH v2 05/17] virtio-balloon: use standard headers Michael S. Tsirkin
2015-02-15 11:38 ` [Qemu-devel] [PATCH v2 06/17] virtio-9p: " Michael S. Tsirkin
2015-02-15 11:38 ` [Qemu-devel] [PATCH v2 07/17] virtio-blk: switch to standard-headers Michael S. Tsirkin
2015-02-15 11:38 ` [Qemu-devel] [PATCH v2 08/17] virtio-net, tap: use standard-headers Michael S. Tsirkin
2015-02-15 11:39 ` [Qemu-devel] [PATCH v2 09/17] virtio-rng: " Michael S. Tsirkin
2015-02-15 11:39 ` [Qemu-devel] [PATCH v2 10/17] virtio-scsi: " Michael S. Tsirkin
2015-02-16 9:30 ` Paolo Bonzini
2015-02-16 11:36 ` Michael S. Tsirkin [this message]
2015-02-16 11:45 ` Peter Maydell
2015-02-16 14:27 ` Paolo Bonzini
2015-03-11 10:13 ` Alexey Kardashevskiy
2015-03-11 10:57 ` Alexey Kardashevskiy
2015-03-11 12:04 ` Michael S. Tsirkin
2015-03-11 12:52 ` Alexey Kardashevskiy
2015-02-15 11:39 ` [Qemu-devel] [PATCH v2 11/17] virtio-serial: switch to standard-headers Michael S. Tsirkin
2015-02-15 11:39 ` [Qemu-devel] [PATCH v2 12/17] update-linux-headers: use standard-headers Michael S. Tsirkin
2015-02-15 11:39 ` [Qemu-devel] [PATCH v2 13/17] linux-headers: " Michael S. Tsirkin
2015-02-15 11:39 ` [Qemu-devel] [PATCH v2 14/17] virtio-pci: use standard headers Michael S. Tsirkin
2015-02-15 11:39 ` [Qemu-devel] [PATCH v2 15/17] scripts: add arch specific standard-headers Michael S. Tsirkin
2015-02-16 15:56 ` Thomas Huth
2015-02-16 16:15 ` Michael S. Tsirkin
2015-02-15 11:39 ` [Qemu-devel] [PATCH v2 16/17] standard-headers: add s390 virtio headers Michael S. Tsirkin
2015-02-15 11:39 ` [Qemu-devel] [PATCH v2 17/17] s390: use standard headers Michael S. Tsirkin
2015-02-15 11:41 ` [Qemu-devel] [PATCH v2 00/17] virtio: pull headers from linux Peter Maydell
2015-02-15 11:43 ` Michael S. Tsirkin
2015-02-16 8:50 ` Cornelia Huck
2015-02-16 9:05 ` Michael S. Tsirkin
2015-02-16 9:32 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216113618.GB20667@redhat.com \
--to=mst@redhat.com \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=cornelia.huck@de.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tiejun.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).