From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57518)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YNJyd-00024i-An
	for qemu-devel@nongnu.org; Mon, 16 Feb 2015 06:36:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YNJya-0002ZH-4J
	for qemu-devel@nongnu.org; Mon, 16 Feb 2015 06:36:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47742)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YNJyZ-0002Yw-Tf
	for qemu-devel@nongnu.org; Mon, 16 Feb 2015 06:36:32 -0500
Date: Mon, 16 Feb 2015 12:36:18 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150216113618.GB20667@redhat.com>
References: <1423999136-17320-1-git-send-email-mst@redhat.com>
	<1423999136-17320-11-git-send-email-mst@redhat.com>
	<54E1B8B0.5060705@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54E1B8B0.5060705@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@amazon.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Stefan Hajnoczi <stefanha@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Chen,
	Tiejun" <tiejun.chen@intel.com>

On Mon, Feb 16, 2015 at 10:30:24AM +0100, Paolo Bonzini wrote:
> 
> 
> On 15/02/2015 12:39, Michael S. Tsirkin wrote:
> > Drop duplicated code.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  include/hw/virtio/virtio-scsi.h | 120 +++-------------------------------------
> >  hw/scsi/virtio-scsi.c           |   1 +
> >  2 files changed, 10 insertions(+), 111 deletions(-)
> > 
> > diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> > index bf17cc9..9bcda7e 100644
> > --- a/include/hw/virtio/virtio-scsi.h
> > +++ b/include/hw/virtio/virtio-scsi.h
> > @@ -14,6 +14,7 @@
> >  #ifndef _QEMU_VIRTIO_SCSI_H
> >  #define _QEMU_VIRTIO_SCSI_H
> >  
> > +#include "standard-headers/sys/virtio_scsi.h"
> 
> Why sys/?  It's linux/, let's keep it linux/.
> 
> Paolo

Peter requested this change: he felt having portable
headers under linux/ is confusing:

http://mid.gmane.org/CAFEAcA8QFTWbBZSPjCKzEBBwWZojJL+LDKTPL_F=eCDpDHj=Zw@mail.gmail.com

Makes sense?

-- 
MST