From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNOI6-0004K4-Bk for qemu-devel@nongnu.org; Mon, 16 Feb 2015 11:12:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNOI3-0007ns-IU for qemu-devel@nongnu.org; Mon, 16 Feb 2015 11:12:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNOI3-0007nc-BN for qemu-devel@nongnu.org; Mon, 16 Feb 2015 11:12:55 -0500 Date: Mon, 16 Feb 2015 17:12:39 +0100 From: "Michael S. Tsirkin" Message-ID: <20150216161239.GC25470@redhat.com> References: <1423839431-3563-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423839431-3563-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/3] pci: fix memory region lifecycle issues, document the rules List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: mjrosato@linux.vnet.ibm.com, alex.williamson@redhat.com, qemu-devel@nongnu.org On Fri, Feb 13, 2015 at 03:57:08PM +0100, Paolo Bonzini wrote: > While these patches were originally in "part 3" of the RCU patches, > it turns out that the semantics they enforce are already important now > (reported by Alex Williamson and Matthew Rosato), so here they are! > > Patch 1 fixes a MemoryRegion leak (and fixes it the right way, so that > the new lifecycle rules are respected!). > > Patch 2 fixes a case where a memory region could be referenced (in > an RCU callback) when it had no parent, similar to the s390 case. > > Patch 3 documents the MemoryRegion lifecycle rules now that (except for > s390, which Matthew is going to fix soon) QEMU actually follows them. > > Please review and ACK. Michael, okay to apply the first two through the > RCU tree? > > Paolo Since you mention you have patches depending on these queued: Acked-by: Michael S. Tsirkin > Paolo Bonzini (3): > pcie: remove mmconfig memory leak and wrap mmconfig update with transaction > pci: split shpc_cleanup and shpc_free > docs: clarify memory region lifecycle > > docs/memory.txt | 74 +++++++++++++++++++++++++++++++++--------- > hw/pci-bridge/pci_bridge_dev.c | 14 +++++--- > hw/pci/pcie_host.c | 7 ++-- > hw/pci/shpc.c | 5 +++ > include/hw/pci/shpc.h | 1 + > 5 files changed, 79 insertions(+), 22 deletions(-) > > -- > 1.8.3.1