From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60101)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YNhYG-0007uF-2l
	for qemu-devel@nongnu.org; Tue, 17 Feb 2015 07:46:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YNhYC-0000kT-3x
	for qemu-devel@nongnu.org; Tue, 17 Feb 2015 07:46:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54372)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YNhYB-0000jO-Lz
	for qemu-devel@nongnu.org; Tue, 17 Feb 2015 07:46:52 -0500
Date: Tue, 17 Feb 2015 18:16:43 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150217124643.GA13104@grmbl.mre>
References: <1423673184-5903-1-git-send-email-dgilbert@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1423673184-5903-1-git-send-email-dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: quintela@redhat.com, liang.z.li@intel.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, pbonzini@redhat.com

On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> This patchset provides a way of setting options on an incoming
> migration before the fd/process/socket has been created.
> 
>    start qemu with   -incoming pause
>    <use the monitor to set whatever you need>
>    migrate_incoming theuri
> 
> v2:
>   Create migrate_incoming/migrate-incoming rather than squashing the -u
>   into the existing migrate command.

So the only comment I have is with the 'pause' name.

'pause' to me means there's a time period for which a pause has to be
done; or pausing an activity which is already in progress, both of
which are not true for this case.

My suggestions are 'wait' or 'hold' -- wait signifies we wait for a
connection; the uri for which we give later; similar for hold.


		Amit